[Laszlo-dev] For Review: Change change.YVyjb5168.txt Summary: Cleanup LFC warnings in LzView

[P T Withington]

I wonder if classChildren and doneClassRoot should just be declared  
in LzView?

var classChildren = null;
var doneClassRoot = false;

rather than testing for them being defined?

This:

              this._a = rp ;
              if ( typeof (this._a) == 'function' ) {
                  this._a();

can be more efficiently written as:

              if ( rp instanceof Function ) {
                  rp.call(this);

Similary:

          // The string check prevents a dhtml error
          if ( typeof(refs[ p ]) != 'string' && ('dependencies' in  
refs[ p ]) && refs[ p ].dependencies ) {
              this._t = refs[ p ].dependencies;
              this.applyConstraint( p , refs[ p ] , this._t() );
          }

Should probably be:

	 var rp = refs[p];
          if ( rp instanceof Function && ('dependencies' in rp)) {
              this.applyConstraint( p , rp , rp.dependencies.call 
(this) );
          }

(and you won't need to delete this._a or this._t, now that they are  
not created).

Otherwise, approved.

On 2006-08-24, at 15:43 EDT, Philip Romanik wrote:

>
> Change change.YVyjb5168.txt by Philip at Philip-DC /tmp/ on 2006-08-24  
> 15:37:09 EDT
>
> Summary: Cleanup LFC warnings in LzView
>
> New Features:
>
> Bugs Fixed: LPP-2034 (partially)
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> Tests:
>
> Files:
> M      LzNode.lzs
> <patch.Philip.4140.tgz>