[Laszlo-dev] For Review: Change change.wvgVMwb6I.txt Summary: Make setters work in LzDataElement

[Jim Grandy]

Yeah, I should have emphasized the problem more than the solution. We  
do need a bookmark in JIRA to remind us to clean this up at some  
point, however we do it. And I agree, what you have here is better  
than the infamous "cheezy multiple inheritance", which was the  
previous solution.

jim

On Aug 23, 2006, at 3:27 PM, P T Withington wrote:

> Not clear.  There is obviously _some_ refactoring that should be  
> done involving creating something lighter weight that sits above  
> Node and embodies core concepts such as the setter (getter,  
> defaults, etc.) mechanism and the DOM parent/child/sibling  
> relations.  I don't think we want to take this on for this bug.   
> What I tried to do here is restore the old mechanism that was  
> apparently lost (or overlooked) in the class transition and make it  
> fit in the new class regime least painfully.
>
> On 2006-08-23, at 17:53 EDT, Jim Grandy wrote:
>
>> It feels like we're sorta dancing around the real solution to this,
>> which is presumably to make LzNode subclass from LzDataElement, and
>> host the setter behavior in LzDataElement.
>>
>> On Aug 23, 2006, at 2:41 PM, P T Withington wrote:
>>
>>> Change change.wvgVMwb6I.txt by ptw at tin-woodsman.local /Users/ptw/
>>> pending-changes/ on 2006-08-23 17:25:43 EDT
>>>
>>> Summary: Make setters work in LzDataElement
>>>
>>> Bugs Fixed:
>>> LPP-2361 test failing in data regression suite in legals
>>>
>>> Technical Reviewer: hminsky (pending)
>>> QA Reviewer: mamye (pending)
>>> Doc Reviewer: n/a
>>>
>>> Details:
>>>     LzDataElement does _not_ inherit from LzNode, but
>>>     LzDataElementTrait expects to be able to define setters.  Create
>>>     LzMiniNode that has just enough of the setter mechanism to  
>>> support
>>>     setters.  Base LzDataElement on that.
>>>
>>> Tests:
>>>     test/lfc/data/alldata.lzx no longer fails with:
>>>     TestFailure: TestDPDepend >>> test2 failed: Equals: expected
>>> "special" got "v"
>>>     TestError: TestDPDepend >>> test2 failed: reference to
>>> undefined property 'setters'
>>>
>>> Files:
>>> M      data/LzDataElement.lzs
>>>
>>> <patch.ptw.EHjj.tgz>
>>>
>>> _______________________________________________
>>> Laszlo-dev mailing list
>>> Laszlo-dev at openlaszlo.org
>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
>>
>> _______________________________________________
>> Laszlo-dev mailing list
>> Laszlo-dev at openlaszlo.org
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev
>