[Laszlo-dev] For Review: Change 41538 Summary: Spiff up dhtml-debugger, should work in IE now

[Benjamin Shine]

Approved!
Rock on!

I filed a bug for myself to make the title bar of the debugger match  
up with the Laszlo branding a little better, http:// 
www.openlaszlo.org/jira/browse/LPP-1968 and a bug for a real designer  
to do a real design pass,
http://www.openlaszlo.org/jira/browse/LPP-1969

On Apr 15, 2006, at 3:38 AM, P T Withington wrote:

> [I'm going to check this in, because it should make your debugging  
> experience a whole lot better]
>
> Change 41538 by ptw at ptw-legals-4 on 2006/04/15 03:05:53 *pending*
>
> 	Summary: Spiff up dhtml-debugger, should work in IE now
> 	
> 	New Features: Debug.info and Debug.debug, like Debug.warn and
> 	Debug.error, because people seem to want them (inspired by
> 	fvlogger).
> 	
> 	Bugs Fixed:
> 	LPP-1960: 'DHTML debugger issues'
> 	LPP-1962: 'Debug.warn, Debug.error, Debug.info don't work in lps- 
> legals dhtml debugger'
> 	LPP-1925: 'Clean LFC subdirs: compiler, debugger, profiler' (partial)
> 	
> 	Technical Reviewer: ben (pending)
> 	QA Reviewer: max (pending)
> 	Doc Reviewer: jsundman (pending)
> 	
> 	Documentation: Debug.info and Debug.debug are just like
> 	Debug.warn but print in a different color.  (Homeland security
> 	mapping: debug = green, info = blue, warn = orange, error =
> 	red.)
> 	
> 	Details:
> 	
> 	LzDebug: move freshLine and freshPrompt processing up to
> 	__write so ben can override addText and not lose that.
> 	Translate \n to <br /> for IE, which does not seem to know how
> 	to implement white-space: pre.  Add some null checks to avoid
> 	barfage in the debugger.  Add some try blocks to catch errors
> 	trying to print objects.  Fix some cases where we were trying
> 	to get properties from non-objects.  Avoid duplicate slot
> 	printing.
> 	
> 	LzDebug, LzMessage: Fix up manipulating arguments for runtimes
> 	where it is not _actually_ an array.  Add .info and .debug.
> 	
> 	JavascriptGenerator: ensure _dbg_name annotation function is
> 	not re-translated.
> 	
> 	app-console.xslt, console.css: Move all inline styles out to
> 	.css, re-arrange the dhtml application and debugger frames to
> 	work better in all browsers.
> 	
> 	Tests: test/bugs/lpp-1960.lzx?lzr=dhtml?debug=true, lpp-1962.lzx? 
> lzr=dhtml?debug=true
>
> Affected files ...
>
> ... //depot/lps-legals/WEB-INF/lps/lfc/debugger/LzDebug.js#2 edit
> ... //depot/lps-legals/WEB-INF/lps/lfc/debugger/LzMessage.js#1 edit
> ... //depot/lps-legals/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> JavascriptGenerator.java#12 edit
> ... //depot/lps-legals/WEB-INF/lps/templates/app-console.xslt#5 edit
> ... //depot/lps-legals/lps/includes/console.css#2 edit
>

benjamin shine
software engineer
ben at laszlosystems.com