[Laszlo-dev] For Review: Change 41085 Summary:Remove string-parametric property access from width/height dependent

P T Withington ptw at openlaszlo.org
Tue Apr 4 12:24:54 EDT 2006


Then we nee macros!

On 2006-04-04 12:17 EDT, Adam Wolff wrote:

> The reason these methods worked this way was not to save space, but  
> for
> maintenance. Of course, these methods used flasm then (I think) so
> maintaining two versions was not an option.
>
> This code is fairly complex, so I'd be concerned that someone would  
> fix a
> bug in one and not the other.
>
> A
>
> On Mar 31, Jim Grandy wrote:
>
>> Change 41085 by jgrandy at jgrandy-dev on 2006/03/31 14:34:00 *pending*
>>
>> 	Summary:Remove string-parametric property access from width/height
>> dependent
>> 	methods in LzView
>> 		Technical Reviewer: ptw (pending)
>> 	QA Reviewer: mdavis (pending)
>> 	Doc Reviewer:
>> 		Details:Rewrite methods to be width- or height-dependent
>> instead of using
>> 	string concatenation to compose property names on the fly. LFC7.lzl
>> size
>> 	changes by 834 bytes as a result of this change.
>> 		Tests:runlzunit, laszlo-explorer
>>
>> Affected files ...
>>
>> ... //depot/lps-dev/WEB-INF/lps/lfc/views/LaszloView.as#39 edit
>>
>>



More information about the Laszlo-dev mailing list