[Laszlo-dev] Re: For Review: Change 35233 Summary:Add a few unit tests for LzNode.

[P T Withington]

Approved!  First in a series of many steps to have a complete LFC API  
test suite.

I have a couple of questions you may or may not want to address:

It's not clear to me that LzNode.subnodes is guaranteed to be in any  
particular order, but in lzunit-node.lzx you are testing that.

Line 65 of lzunit-node-initsequence seems confused:
>         var testname = testname = this.name;

Do you need a more complex structure to test the difference between  
normal and immediate?  They seem to have the same result.

In lzunit-node-replication.lzx you say:
>         // doesn't work until LzNode.searchSubnodes is fixed to  
> search subnodes instead of subviews.
but the test itself is not commented out?

On 28 Nov 2005, at 20:05, Jim Grandy wrote:

> Change 35233 by jgrandy at jgrandy-dev on 2005/11/28 17:02:32 *pending*
>
> 	Summary:Add a few unit tests for LzNode.
> 	
> 	Technical Reviewer: ptw (pending)
> 	QA Reviewer: frisco (pending)
> 	Doc Reviewer:
> 	
> 	Details: I wrote these in part to understand how initialization  
> and initstage works
> 	
> Affected files ...
>
> ... //depot/lps-dev/test/lfc/lzunit-node-initsequence.lzx#1 add
> ... //depot/lps-dev/test/lfc/lzunit-node-replication.lzx#1 add
> ... //depot/lps-dev/test/lfc/lzunit-node.lzx#1 add
> ... //depot/lps-dev/test/lzunit/testpaths.txt#2 edit
>
> <changeset-35233.zip>