[Laszlo-dev] For Review: Change 35165 Summary: Make obfuscate=false work

Oliver Steele osteele at laszlosystems.com
Wed Nov 23 13:59:02 PST 2005


On Nov 23, 2005, at 4:42 PM, P T Withington wrote:
> Because the obfuscated for loop already did not use temporary  
> labels as tags (so they were not getting clobbered).

Thanks.

I had forgotten that the for loop was obfuscated too.

Approved.

> On 23 Nov 2005, at 16:40, Oliver Steele wrote:
>
>> How was obfuscation fixing the wild jumps?
>>
>> On Nov 23, 2005, at 12:44 PM, P T Withington wrote:
>>> Change 35165 by ptw at ptw-dev-four on 2005/11/23 08:39:44 *pending*
>>>
>>> 	Summary: Make obfuscate=false work
>>> 	
>>> 	Bugs Fixed:
>>> 	LPP-238 'Remove LFC obfuscatation' (partial)
>>> 	
>>> 	Technical Reviewer: osteele (pending)
>>> 	QA Reviewer: frisco (pending)
>>> 	Doc Reviewer: n/a (pending)
>>> 	
>>> 	Details: You can't use temporary labels for break/continue
>>> 	because the may collide with temporary labels generated in
>>> 	expanding the body of the block.
>>> 	
>>> 	Tests: Before this change, turning obfuscation off and
>>> 	compiling/decompiling LFC resulted in 'wild jumps'.  After it
>>> 	does not.
>>>
>>> Affected files ...
>>>
>>> ... //depot/lps-dev/WEB-INF/lps/server/sc/Compiler.py#26 edit
>>>
>>>
>>> <changeset-35165.zip>



More information about the Laszlo-dev mailing list