[Laszlo-dev] For Review: Change 35087 Summary: Baseslider and basecomponent unit tests, plus more tweaks to baseslider implementation.

[Jim Grandy]

Change 35087 by jgrandy at jgrandy-dev on 2005/11/21 12:08:52 *pending*

	Summary: Baseslider and basecomponent unit tests, plus more tweaks  
to baseslider implementation.
	
	Technical Reviewer: max (pending)
	QA Reviewer: frisco (pending)
	Doc Reviewer:  (pending)
	
	Details:Expand baseslider unit test, start basecomponent unit test.  
Register both unit tests with runlzunit.
	
	Also improve baseslider init-time behavior. Now we bail out of all  
three setters if isinit is false, and do the
	right thing in an init() override function to check boundary  
conditions and trigger on* events. This requires
	a bit of code duplication between the setters and the init function,  
but is worth it in this case because of
	the circular dependencies between value, minvalue and maxvalue.
	
	Tests:
	
	Baseslider changes tested by test/components/base/lzunit- 
baseslider.lzx.

Affected files ...

... //depot/lps-dev/lps/components/base/baseslider.lzx#4 edit
... //depot/lps-dev/test/components/base/lzunit-basebutton.lzx#1 add
... //depot/lps-dev/test/components/base/lzunit-baseslider.lzx#1 add
... //depot/lps-dev/test/components/lz/lzunit-components.lzx#5 edit
... //depot/lps-dev/test/components/lz/lzunit-slider.lzx#1 delete
... //depot/lps-dev/test/lzunit/testpaths.txt#1 edit

-------------- next part --------------
A non-text attachment was scrubbed...
Name: changeset-35087.zip
Type: application/zip
Size: 14291 bytes
Desc: not available
Url : http://openlaszlo.org/pipermail/laszlo-dev/attachments/20051121/e8c58e15/changeset-35087-0001.zip
-------------- next part --------------