[Laszlo-checkins] r16684 - openlaszlo/trunk/WEB-INF/lps/lfc/controllers

[max@openlaszlo.org]

Author: max
Date: 2010-06-09 14:53:15 -0700 (Wed, 09 Jun 2010)
New Revision: 16684

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
Log:
Change 20100609-maxcarlson-k by maxcarlson at Friendly.local on 2010-06-09 15:01:28 MDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix regression in animators with a from attribute

Bugs Fixed: LPP-9102 - regression: <animator to="..." .../> won't work on attributes with a null value

Technical Reviewer: ptw
QA Reviewer: mdemmon

Details: LzAnimatorGroup - Fix comments that were breaking the doc system

LaszloAnimation - Capture initial values after from has been applied

Tests: See LPP-9102



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs	2010-06-09 21:03:27 UTC (rev 16683)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloAnimation.lzs	2010-06-09 21:53:15 UTC (rev 16684)
@@ -221,9 +221,6 @@
             // create a default hash
             expected = targ.__animatedAttributes = {};
         }
-        if (expected[attr] == null) {
-            expected[attr] = Number(targ[attr]);
-        }
         
         // Set the attribute of the view to its "from" value but make sure
         // expectedAttribute is updated.
@@ -231,6 +228,11 @@
             targ.setAttribute(attr, Number(this.from));
         }
 
+        // update here in case from updated
+        if (expected[attr] == null) {
+            expected[attr] = Number(targ[attr]);
+        }
+
         if (this.relative) {
             this.to = this.origto;
         } else {

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs	2010-06-09 21:03:27 UTC (rev 16683)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs	2010-06-09 21:53:15 UTC (rev 16684)
@@ -170,7 +170,7 @@
 
     /** The start value for the animation.  Defaults to the
       * targeted attribute's current value.
-      * @devnote must be type * so it can be tested for null !&#!# AS3...
+      * @devnote must be type * so it can be tested for null !#!# AS3...
       * @type Number
       * @lzxtype number
       */
@@ -178,7 +178,7 @@
 
     /** The final value for the targeted attribute.
       *
-      * @devnote must be type * so it can be tested for null !&#!# AS3...
+      * @devnote must be type * so it can be tested for null !#!# AS3...
       * @type Number
       * @lzxtype number
       */