[Laszlo-checkins] r16554 - openlaszlo/trunk/lps/components/base
bargull@openlaszlo.org
bargull at openlaszlo.org
Tue Jun 1 02:23:46 PDT 2010
Author: bargull
Date: 2010-06-01 02:23:44 -0700 (Tue, 01 Jun 2010)
New Revision: 16554
Modified:
openlaszlo/trunk/lps/components/base/baselist.lzx
Log:
Change 20100601-bargull-dHa by bargull at Bargull02 on 2010-06-01 11:19:01
in /home/anba/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: prevent npe in <baselist>#_dokeydown()
New Features:
Bugs Fixed: LPP-9062 (NPE in baselist._dokeydown())
Technical Reviewer: (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Overview:
Details:
Only extend selection and highlight the next view if it actually exists, therefore if next!=null .
Tests:
see bugreport
Modified: openlaszlo/trunk/lps/components/base/baselist.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/baselist.lzx 2010-06-01 09:21:57 UTC (rev 16553)
+++ openlaszlo/trunk/lps/components/base/baselist.lzx 2010-06-01 09:23:44 UTC (rev 16554)
@@ -189,11 +189,13 @@
if ( s is lz.view ) {
s.setHilite(false);
}
- // If shift is down, extend the selection
- if (next.enabled && _selector.isRangeSelect(next)) {
- next.setAttribute('selected', true);
+ if (next) {
+ // If shift is down, extend the selection
+ if (next.enabled && _selector.isRangeSelect(next)) {
+ next.setAttribute('selected', true);
+ }
+ next.setHilite(true);
}
- next.setHilite(true);
this._hiliteview = next;
}
]]>
More information about the Laszlo-checkins
mailing list