[Laszlo-checkins] r13850 - openlaszlo/trunk/lps/components/base

[bargull@openlaszlo.org]

Author: bargull
Date: 2009-05-09 14:42:36 -0700 (Sat, 09 May 2009)
New Revision: 13850

Modified:
   openlaszlo/trunk/lps/components/base/basedatacombobox.lzx
Log:
Change 20090509-bargull-r9X by bargull at dell--p4--2-53 on 2009-05-09 23:35:31
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: null-pointer dereferencing in basedatacombobox

New Features:

Bugs Fixed: LPP-8159 (nullptr exception datacombobox for single item)

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
'cloneManager' is 'null' if no clones were created, so check that condition in the if-clause.
    

Tests:
see bugreport



Modified: openlaszlo/trunk/lps/components/base/basedatacombobox.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/basedatacombobox.lzx	2009-05-09 21:34:30 UTC (rev 13849)
+++ openlaszlo/trunk/lps/components/base/basedatacombobox.lzx	2009-05-09 21:42:36 UTC (rev 13850)
@@ -467,7 +467,7 @@
                 var sv = svs[0];
                 if (sv) {
                     var cl = sv.cloneManager;
-                    if (cl['clones']) {
+                    if (cl && cl['clones']) {
                         var pos = cl.clones[0].datapath.xpathQuery( 'position()' ) - 1;
                         item = cl.clones[ index - pos ];
                     } else {