[Laszlo-checkins] r13480 - in openlaszlo/trunk/WEB-INF/lps/lfc: controllers core data

[bargull@openlaszlo.org]

Author: bargull
Date: 2009-03-26 04:21:20 -0700 (Thu, 26 Mar 2009)
New Revision: 13480

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
Log:
Change 20090326-bargull-IHD by bargull at dell--p4--2-53 on 2009-03-26 11:52:18
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: remove constructWithArgs()

New Features:

Bugs Fixed: LPP-7905 (Noticable performance differences between OL 4.0.x and 4.2.x) (partial)

Technical Reviewer: ptw
QA Reviewer: max
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
This removes another (most times) unnecessary function-call. constructWithArgs() was only used in LzReplicationManager and LaszloLayout as a callback after __LZapplyArgs() has been called, so after the arguments were installed.  
    

Tests:



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloLayout.lzs	2009-03-26 10:57:49 UTC (rev 13479)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LaszloLayout.lzs	2009-03-26 11:21:20 UTC (rev 13480)
@@ -174,7 +174,11 @@
 /**
   * @access private
   */
-override function constructWithArgs ( args ) {
+override function __LZapplyArgs ( args , constcall = null ){
+    super.__LZapplyArgs(args, constcall);
+    // If a replicator was made, we're deleted, if pooling is off.
+    if (this.__LZdeleted) { return; }
+
     //all layouts need to know when their view adds/deletes a subview
     this.delegates.push( new LzDelegate (  this, "gotNewSubview",
                                         this.immediateparent,"onaddsubview" ));

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs	2009-03-26 10:57:49 UTC (rev 13479)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs	2009-03-26 11:21:20 UTC (rev 13480)
@@ -325,19 +325,11 @@
     }
     this.__LzValueExprs = null;
 
-    //        this.setClassEvents( this.constructor );
-
     this.__LZapplyArgs( iargs , true );
 
     // If a replicator was made, we're deleted, if pooling is off.
     if (this.__LZdeleted) { return; }
 
-    /**
-     * TODO: [2006-05-24 ptw] Adam says this is a hack that we should get
-     * rid of. [2008-12-05 ptw] Some day!
-     */
-    this.constructWithArgs( iargs );
-
     this.__LZdeferDelegates = false;
     var evq = this.__LZdelegatesQueue;
     if (evq) {
@@ -369,11 +361,6 @@
   }
 
   /**
-   * @access private
-   */
-  function constructWithArgs(args:*) { }
-
-  /**
    * This event is sent after the <varname>node</varname>'s
    * <method>init</method> method has been called.  Simple actions
    * that need to occur after the node's children have been

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs	2009-03-26 10:57:49 UTC (rev 13479)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs	2009-03-26 11:21:20 UTC (rev 13480)
@@ -416,7 +416,11 @@
 /**
   * @access private
   */
-override function constructWithArgs ( args ){
+override function __LZapplyArgs ( args , constcall = null ){
+    super.__LZapplyArgs(args, constcall);
+    // If a replicator was made, we're deleted, if pooling is off.
+    if (this.__LZdeleted) { return; }
+
     this.__LZHandleMultiNodes( this.initialnodes );
     this.initialnodes = null;
     // TODO [hqm 2008-06-17] why do we need to handle this case