[Laszlo-checkins] r14127 - in openlaszlo/trunk: WEB-INF/lps/lfc/services lps/includes/source

[ptw@openlaszlo.org]

Author: ptw
Date: 2009-06-12 11:49:14 -0700 (Fri, 12 Jun 2009)
New Revision: 14127

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/services/LzModeManager.lzs
   openlaszlo/trunk/lps/includes/source/embednew.js
Log:
Change 20090611-ptw-8 by ptw at dueling-banjos.home on 2009-06-11 16:11:19 EDT
    in /Users/ptw/OpenLaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Ensure DHTML app has focus when loaded

Bugs Fixed: LPP-8242 OL4.4 - DHTML: The UP, DOWN keys and space bar are invalid for Textlistitem on WinXP/FF3

Technical Reviewer: a.bargull at intensis.de (Message-ID: <4A32460B.5050708 at udo.edu>)
QA Reviewer: dju at laszlosystems.com (pending)

Details:
    LzModeManager:  Removed some platform-specific code that is no
    longer necessary now that all platforms use the same debugger.

    embednew:  Restore window focus for Firefox on Windows once the
    DHTML application is added to the DOM

Tests:
    Test case from bug



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/services/LzModeManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/services/LzModeManager.lzs	2009-06-12 17:04:31 UTC (rev 14126)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/services/LzModeManager.lzs	2009-06-12 18:49:14 UTC (rev 14127)
@@ -179,14 +179,8 @@
                         this.remotedebug = (lz.Browser.getInitArg("lzconsoledebug") == "true");
                     }
                 }
-                if ($as2) {
-                    if (!this.remotedebug && view.childOf(Debug.console))
-                        break;
-                } else if ($as3) {
-                    if (!this.remotedebug && view.childOf(Debug.console.window))
-                        break;
-                } else if ($dhtml) {
-                    // DHTML-Debugger is not part of the lzx-application
+                if (!this.remotedebug && view.childOf(Debug.console.window)) {
+                  break;
                 }
             }
 
@@ -229,14 +223,8 @@
                     this.remotedebug = (lz.Browser.getInitArg("lzconsoledebug") == "true");
                 }
             }
-            if ($as2) {
-                if (!this.remotedebug && input.childOf(Debug.console))
-                    return true;
-            } else if ($as3) {
-                if (!this.remotedebug && input.childOf(Debug.console.window))
-                    return true;
-            } else if ($dhtml) {
-                // DHTML-Debugger is not part of the lzx-application
+            if (!this.remotedebug && input.childOf(Debug.console.window)) {
+              return true;
             }
         }
 

Modified: openlaszlo/trunk/lps/includes/source/embednew.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/embednew.js	2009-06-12 17:04:31 UTC (rev 14126)
+++ openlaszlo/trunk/lps/includes/source/embednew.js	2009-06-12 18:49:14 UTC (rev 14127)
@@ -261,6 +261,8 @@
         }
 
         this.__dhtmlLoadScript(url)
+        // Make sure we have focus (see LPP-8242)
+        if (lz.embed.browser.OS == 'Windows' && lz.embed.browser.isFirefox) { window.focus(); }
     }
     ,/** A hash of applications installed on the page keyed by id */
     applications: {}