[Laszlo-checkins] r14360 - openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml

max@openlaszlo.org max at openlaszlo.org
Tue Jul 21 06:13:11 PDT 2009


Author: max
Date: 2009-07-21 06:13:08 -0700 (Tue, 21 Jul 2009)
New Revision: 14360

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
Log:
Change 20090720-maxcarlson-I by maxcarlson at Bank.local on 2009-07-20 16:19:41 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix selection mechanism for IE DHTML

Bugs Fixed: LPP-8339 - DHTML - IE 7 - Using OL 4.5.x.0 (14329) to compiled the latest build with webtop jade trunk - does not work with IE 7 (no login,)

Technical Reviewer: ptw
QA Reviewer: hminsky

Details: This line intruduced in r14329 was a problem for IE:
delete this.__LZdiv.style['cursor'];

I changed it to explicitly set the style, based on the default value.

Tests: webtop starts up again in IE7 dhtml.  Also, this testcase still works - the first line is not selectable and has the default cursor.  The second line is selectable.  Clicking the button turns off selectable for the second line and shows the default cursor:
<canvas> 
    <simplelayout/>
    <text>Hello Laszlo!</text>
    <text name="foo" selectable="true">Hello Laszlo!</text>
    <button onclick="foo.setAttribute('selectable', false)">unselectable</button>
</canvas>



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js	2009-07-21 08:00:05 UTC (rev 14359)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js	2009-07-21 13:13:08 UTC (rev 14360)
@@ -554,7 +554,7 @@
             this.__LZdiv.style['UserSelect'] = 'text';
         }
     } else {
-        delete this.__LZdiv.style['cursor'];
+        this.__LZdiv.style['cursor'] = '';
         if (browser.isIE) {
             this.__LZdiv.onselectstart = LzTextSprite.prototype.__cancelhandler;
         } else if (browser.isFirefox) {



More information about the Laszlo-checkins mailing list