[Laszlo-checkins] r14350 - openlaszlo/trunk/lps/components/extensions

max@openlaszlo.org max at openlaszlo.org
Sat Jul 18 11:25:16 PDT 2009


Author: max
Date: 2009-07-18 11:25:14 -0700 (Sat, 18 Jul 2009)
New Revision: 14350

Modified:
   openlaszlo/trunk/lps/components/extensions/html.lzx
Log:
Change 20090717-maxcarlson-R by maxcarlson at Bank.local on 2009-07-17 19:22:03 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Make default target for html component this when one is not specified.

Bugs Fixed: LPP-8044 - html component doesn't sync iframe if no target is provided

Technical Reviewer: hminsky
QA Reviewer: mdemmon

Details: Make the default target attribute this.parent.  Clean up oninit handler.  Update documentation on target attribute.

Tests: webtop.  Also load examples/extensions/html.lzx, click the 'Load' button then drag and resize the window in swf and dhtml.



Modified: openlaszlo/trunk/lps/components/extensions/html.lzx
===================================================================
--- openlaszlo/trunk/lps/components/extensions/html.lzx	2009-07-18 17:35:15 UTC (rev 14349)
+++ openlaszlo/trunk/lps/components/extensions/html.lzx	2009-07-18 18:25:14 UTC (rev 14350)
@@ -138,11 +138,11 @@
     ]]>
     </setter>
 
-    <!--- Sets the view to listen to for x/y/width/height change events.
+    <!--- Sets the view to listen to for x/y/width/height change events.  Defaults to this.parent.
           @type LzView
           @access public
     -->
-    <attribute name="target" value="null"/>
+    <attribute name="target" value="${this.parent}"/>
     <!--- Sets the name/target of the html iframe.
           @type String
           @access public
@@ -205,9 +205,6 @@
 
     <!--- @access private -->
     <handler name="oninit">
-        if (this['target'] == null) {
-            this.setAttribute('target', this.parent);
-        }
         if ($dhtml) {
             var i = lz.embed.iframemanager.create(this, this.framename, this.scrollbars, this.sprite.__LZdiv, 0, canvas);
         } else {



More information about the Laszlo-checkins mailing list