[Laszlo-checkins] r14329 - openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml

[ptw@openlaszlo.org]

Author: ptw
Date: 2009-07-15 12:16:58 -0700 (Wed, 15 Jul 2009)
New Revision: 14329

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
   openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
Log:
Change 20090714-ptw-B by ptw at dueling-banjos.home on 2009-07-14 19:10:57 EDT
    in /Users/ptw/OpenLaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Don't display I-Beam cursor over non-selectable text

Bugs Fixed: LPP-8312 Amazon (dhtml): wrong mouse pointer for text

Technical Reviewer: a.bargull at intensis.de (pending)
QA Reviewer: max (Message-ID: <4A5D2415.8020201 at laszlosystems.com>)

Details:
    LzSprite:  remove unused style lzinputclickdiv, set the cursor for
    lztextcontainer to 'default'.

    LzTextSprite:  When text is selectable, set the cursor to 'auto'.

Tests:
    Amazon no longer displays an I-Beam in static text, but the search
    box and
      <text selectable="true">This is a test</text>
    can still be selected and copied.



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js	2009-07-15 15:47:27 UTC (rev 14328)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js	2009-07-15 19:16:58 UTC (rev 14329)
@@ -231,9 +231,6 @@
     lzclickdiv: {
         position: 'absolute'
     },
-    lzinputclickdiv: {
-        position: 'absolute'
-    },
     lzcanvasdiv: {
         position: 'absolute'
     },
@@ -249,7 +246,10 @@
         paddingTop: '2px',
         paddingRight: '2px',
         paddingBottom: '2px',
-        paddingLeft: '2px'
+        paddingLeft: '2px',
+        // By default our text is not selectable, so we don't want an
+        // 'auto' cursor
+        cursor: 'default'
     },
     // TODO [hqm 2009-04] This is a duplicate of lztextcontainer
     // above, but without overflow='hidden', as a fix for
@@ -263,7 +263,10 @@
         paddingTop: '2px',
         paddingRight: '2px',
         paddingBottom: '2px',
-        paddingLeft: '2px'
+        paddingLeft: '2px',
+        // By default our text is not selectable, so we don't want an
+        // 'auto' cursor
+        cursor: 'default'
     },
     lzinputtextcontainer: {
         position: 'absolute',

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js	2009-07-15 15:47:27 UTC (rev 14328)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js	2009-07-15 19:16:58 UTC (rev 14329)
@@ -543,6 +543,7 @@
     var browser = lz.embed.browser;
 
     if (s) {
+        this.__LZdiv.style['cursor'] = 'auto';
         if (browser.isIE) {
             this.__LZdiv.onselectstart = null;
         } else if (browser.isFirefox) {
@@ -552,7 +553,8 @@
         } else {
             this.__LZdiv.style['UserSelect'] = 'text';
         }
-    } else {    
+    } else {
+        delete this.__LZdiv.style['cursor'];
         if (browser.isIE) {
             this.__LZdiv.onselectstart = LzTextSprite.prototype.__cancelhandler;
         } else if (browser.isFirefox) {