[Laszlo-checkins] r14297 - in openlaszlo/branches/4.2: . WEB-INF/lps/lfc/helpers

ptw@openlaszlo.org ptw at openlaszlo.org
Thu Jul 9 08:57:36 PDT 2009 

Author: ptw
Date: 2009-07-09 08:57:34 -0700 (Thu, 09 Jul 2009)
New Revision: 14297

Modified:
   openlaszlo/branches/4.2/
   openlaszlo/branches/4.2/WEB-INF/lps/lfc/helpers/LzCommand.lzs
Log:
Merged revisions 14296 via svnmerge from 
http://svn.openlaszlo.org/openlaszlo/trunk

.......
  r14296 | ptw | 2009-07-09 11:50:01 -0400 (Thu, 09 Jul 2009) | 18 lines
  
  Change 20090709-ptw-K by ptw at dueling-banjos.home on 2009-07-09 11:45:15 EDT
      in /Users/ptw/OpenLaszlo/trunk
      for http://svn.openlaszlo.org/openlaszlo/trunk
  
  Summary: Clean up command on destroy
  
  Bugs Fixed: LPP-8326 Command tag causes a memory leak
  
  Technical Reviewer: max (pending)
  QA Reviewer: Ammar.Tazami at corp.G.ho.st (pending)
  
  Details:
      A command needs to remove itself from any keyboard shortcut when destroyed.
  
  Tests:
      Test case from bug report
.......



Property changes on: openlaszlo/branches/4.2
___________________________________________________________________
Name: svnmerge-integrated
   - /openlaszlo/branches/4.1:1-10153 /openlaszlo/branches/devildog:1-8432 /openlaszlo/branches/pagan-deities:1-7955,8825,10756-10920,10922-10928,10930-10935,11151,11207,11554 /openlaszlo/branches/paperpie:1-6504,6506-6574,6576-7135,7137-7235 /openlaszlo/branches/wafflecone:1-5746,5818-6068,6070-6205,6207-6213,6216-6265,6267-6368,6370-6431,6433-6450,6497,6509,6661,7097,7872 /openlaszlo/trunk:1-12154,12172-12175,12177-12185,12187-12194,12196,12201,12208,12229,12251-12252,12254-12255,12257-12258,12260,12262-12266,12268-12269,12271-12275,12278-12285,12303,12318-12323,12340-12348,12352,12354-12358,12360-12361,12363,12365-12367,12369-12371,12375-12378,12380-12389,12391,12394-12396,12399-12400,12402-12403,12406-12416,12419-12422,12424-12429,12431-12433,12435,12437-12441,12443,12445,12447,12449-12451,12453-12454,12457-12460,12464,12466-12475,12477-12480,12482-12490,12493-12495,12499-12502,12507-12510,12512,12514-12520,12522,12525-12531,12534-12540,12542,12545,12548-12554,12557-12561,12564,12566-12568,12571,12574-12576,12578,12580,12583-12584,12586-12587,12589,12592-12596,12598-12600,12602-12609,12611-12615,12617,12619-12621,12623,12625,12628-12631,12633-12635,12637,12639,12642,12644,12647-12653,12656,12658,12660,12662-12666,12668-12694,12696,12698-12704,12708-12710,12712-12721,12723-12729,12731-12742,12745-12752,12754-12784,12786-12791,12793-12798,12800-12801,12803,12805-12808,12810-12812,12814,12816-12821,12825-12833,12835-12837,12839-12841,12847,12849-12859,12863-12883,12885-12895,12897-12906,12908-12915,12917-12922,12924-12934,12937-12940,12943-12944,12946-12947,12950-12952,12955-12964,12966-12969,12971,12973-12977,12979-12993,12997-12999,13001-13003,13006-13007,13010-13015,13017-13020,13022-13024,13026-13031,13033,13035-13037,13039-13040,13043,13046-13052,13055-13060,13062-13069,13071-13072,13074,13076-13085,13087-13093,13095-13101,13103-13104,13106,13108-13110,13112,13114-13122,13125-13126,13128-13136,13139-13140,13142,13147,13157-13158,13163,13167,13176,13186,13188,13195,13200,13225,13243,13272,13345,1336!
 0,13362-
13363,13365,13367-13371,13373-13375,13377,13380-13382,13428,13453-13454,13456-13458,13460-13465,13469-13471,13474-13479,13481-13482,13484-13485,13487-13496,13500-13501,13503,13505,13507-13508,13510,13512-13515,13518-13522,13524,13527,13529,13531,13534-13536,13541-13545,13548-13550,13552-13553,13555-13556,13558,13560-13561,13564-13565,13567-13571,13574,13576-13577,13579-13580,13582-13585,13587,13590-13596,13599-13600,13602-13604,13606-13608,13610,13612,13614-13615,13619-13626,13628-13629,13631-13641,13643-13663,13665,13667-13670,13672,13674,13676-13679,13682,13684-13685,13689-13690,13692-13694,13696-13697,13700,13702,13704-13708,13710,13712-13713,13716,13718-13728,13732-13733,13735-13739,13816
   + /openlaszlo/branches/4.1:1-10153 /openlaszlo/branches/devildog:1-8432 /openlaszlo/branches/pagan-deities:1-7955,8825,10756-10920,10922-10928,10930-10935,11151,11207,11554 /openlaszlo/branches/paperpie:1-6504,6506-6574,6576-7135,7137-7235 /openlaszlo/branches/wafflecone:1-5746,5818-6068,6070-6205,6207-6213,6216-6265,6267-6368,6370-6431,6433-6450,6497,6509,6661,7097,7872 /openlaszlo/trunk:1-12154,12172-12175,12177-12185,12187-12194,12196,12201,12208,12229,12251-12252,12254-12255,12257-12258,12260,12262-12266,12268-12269,12271-12275,12278-12285,12303,12318-12323,12340-12348,12352,12354-12358,12360-12361,12363,12365-12367,12369-12371,12375-12378,12380-12389,12391,12394-12396,12399-12400,12402-12403,12406-12416,12419-12422,12424-12429,12431-12433,12435,12437-12441,12443,12445,12447,12449-12451,12453-12454,12457-12460,12464,12466-12475,12477-12480,12482-12490,12493-12495,12499-12502,12507-12510,12512,12514-12520,12522,12525-12531,12534-12540,12542,12545,12548-12554,12557-12561,12564,12566-12568,12571,12574-12576,12578,12580,12583-12584,12586-12587,12589,12592-12596,12598-12600,12602-12609,12611-12615,12617,12619-12621,12623,12625,12628-12631,12633-12635,12637,12639,12642,12644,12647-12653,12656,12658,12660,12662-12666,12668-12694,12696,12698-12704,12708-12710,12712-12721,12723-12729,12731-12742,12745-12752,12754-12784,12786-12791,12793-12798,12800-12801,12803,12805-12808,12810-12812,12814,12816-12821,12825-12833,12835-12837,12839-12841,12847,12849-12859,12863-12883,12885-12895,12897-12906,12908-12915,12917-12922,12924-12934,12937-12940,12943-12944,12946-12947,12950-12952,12955-12964,12966-12969,12971,12973-12977,12979-12993,12997-12999,13001-13003,13006-13007,13010-13015,13017-13020,13022-13024,13026-13031,13033,13035-13037,13039-13040,13043,13046-13052,13055-13060,13062-13069,13071-13072,13074,13076-13085,13087-13093,13095-13101,13103-13104,13106,13108-13110,13112,13114-13122,13125-13126,13128-13136,13139-13140,13142,13147,13157-13158,13163,13167,13176,13186,13188,13195,13200,13225,13243,13272,13345,1336!
 0,13362-
13363,13365,13367-13371,13373-13375,13377,13380-13382,13428,13453-13454,13456-13458,13460-13465,13469-13471,13474-13479,13481-13482,13484-13485,13487-13496,13500-13501,13503,13505,13507-13508,13510,13512-13515,13518-13522,13524,13527,13529,13531,13534-13536,13541-13545,13548-13550,13552-13553,13555-13556,13558,13560-13561,13564-13565,13567-13571,13574,13576-13577,13579-13580,13582-13585,13587,13590-13596,13599-13600,13602-13604,13606-13608,13610,13612,13614-13615,13619-13626,13628-13629,13631-13641,13643-13663,13665,13667-13670,13672,13674,13676-13679,13682,13684-13685,13689-13690,13692-13694,13696-13697,13700,13702,13704-13708,13710,13712-13713,13716,13718-13728,13732-13733,13735-13739,13816,14296

Modified: openlaszlo/branches/4.2/WEB-INF/lps/lfc/helpers/LzCommand.lzs
===================================================================
--- openlaszlo/branches/4.2/WEB-INF/lps/lfc/helpers/LzCommand.lzs	2009-07-09 15:50:01 UTC (rev 14296)
+++ openlaszlo/branches/4.2/WEB-INF/lps/lfc/helpers/LzCommand.lzs	2009-07-09 15:57:34 UTC (rev 14297)
@@ -1,6 +1,6 @@
 /**
   *
-  * @copyright Copyright 2001-2008 Laszlo Systems, Inc.  All Rights Reserved.
+  * @copyright Copyright 2001-2009 Laszlo Systems, Inc.  All Rights Reserved.
   *            Use is subject to license terms.
   *
   * @affects lzcommand
@@ -53,10 +53,22 @@
 var keys = null;
 /** @access private */
 function $lzc$set_key(k) {
+    var oldKeys = this.keys;
+    if (oldKeys) {
+      lz.Keys.removeKeyComboCall(this, oldKeys);
+    }
     this.keys = k;
     lz.Keys.callOnKeyCombo( this , k );
 }
 
+override function destroy () {
+    var oldKeys = this.keys;
+    if (oldKeys) {
+      lz.Keys.removeKeyComboCall(this, oldKeys);
+    }
+    super.destroy();
+}
+
 /**
   * If the command is active, this event is sent
   * when the keys array are pressed simultaneously.

More information about the Laszlo-checkins mailing list