[Laszlo-checkins] r12707 - openlaszlo/trunk/docs/src/xsl

[dda@openlaszlo.org]

Author: dda
Date: 2009-02-01 09:35:53 -0800 (Sun, 01 Feb 2009)
New Revision: 12707

Modified:
   openlaszlo/trunk/docs/src/xsl/common-html.xsl
   openlaszlo/trunk/docs/src/xsl/dbkpreprocessexamples.xsl
Log:
Change 20090130-dda-r by dda at lester-2.local on 2009-01-30 08:26:48 EST
    in /Users/dda/laszlo/src/svn/openlaszlo/trunk-doc2
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: doc examples get width=100% when unspecified

New Features:

Bugs Fixed: LPP-7694 [Example canvas's should be width="100%"]

Technical Reviewer: (pending)
QA Reviewer: (pending)
Doc Reviewer: liorio (pending)

Documentation:

Release Notes:

Details:
  In fixing LPP-5207 an unspecified height was correctly defaulted to 400,
  so as not to take up large amount of vertical space.
  But also an unspecified width was defaulted to 500, and any fixed width is a mistake.
  The simplest solution is to change 500 to 100% in the two places it occurs,
  and this works adequately.

Tests:
  Rebuilt the developers doc and observed that the faulty case works.
    http://127.0.0.1:8080/trunk/docs/developers/color.html#csscolors
  Also measured the 'Basevaluecomponent' example that appears in 
    http://127.0.0.1:8080/trunk/docs/developers/custom-components.html
  to make sure that the issue that Ben struggled over in LPP-5207 remains resolved.



Modified: openlaszlo/trunk/docs/src/xsl/common-html.xsl
===================================================================
--- openlaszlo/trunk/docs/src/xsl/common-html.xsl	2009-02-01 17:34:17 UTC (rev 12706)
+++ openlaszlo/trunk/docs/src/xsl/common-html.xsl	2009-02-01 17:35:53 UTC (rev 12707)
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- * X_LZ_COPYRIGHT_BEGIN ***************************************************
-* Copyright 2001-2008 Laszlo Systems, Inc.  All Rights Reserved.              *
+* Copyright 2001-2009 Laszlo Systems, Inc.  All Rights Reserved.              *
 * Use is subject to license terms.                                            *
 * X_LZ_COPYRIGHT_END ****************************************************** -->
 <!DOCTYPE xsl:stylesheet [
@@ -248,7 +248,7 @@
     <xsl:variable name="fname" select="textobject/textdata/@fileref"/>
     <xsl:variable name="query-parameters" select="parameter[@role='query']"/>
 
-    <!--If no canvas parameters are specified, set height to 400px and width to 500.
+    <!--If no canvas parameters are specified, set height to 400px.
       This fixes     LPP-5207 change height of example code window from 200 to 400 pixels
       [bshine 12.16.2007]
     -->         
@@ -407,7 +407,7 @@
         <xsl:call-template name="get-canvas-attribute">
           <xsl:with-param name="text" select="string($text)"/>
           <xsl:with-param name="attribute" select="'width'"/>
-          <xsl:with-param name="default" select="'500'"/>
+          <xsl:with-param name="default" select="'100%'"/>
         </xsl:call-template>
       </xsl:variable>
       <xsl:variable name="canvas-height">

Modified: openlaszlo/trunk/docs/src/xsl/dbkpreprocessexamples.xsl
===================================================================
--- openlaszlo/trunk/docs/src/xsl/dbkpreprocessexamples.xsl	2009-02-01 17:34:17 UTC (rev 12706)
+++ openlaszlo/trunk/docs/src/xsl/dbkpreprocessexamples.xsl	2009-02-01 17:35:53 UTC (rev 12707)
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- * X_LZ_COPYRIGHT_BEGIN ***************************************************
-* Copyright 2007 Laszlo Systems, Inc.  All Rights Reserved.                   *
+* Copyright 2007, 2009 Laszlo Systems, Inc.  All Rights Reserved.                   *
 * Use is subject to license terms.                                            *
 * X_LZ_COPYRIGHT_END ****************************************************** -->
 <!DOCTYPE xsl:stylesheet [
@@ -125,9 +125,9 @@
       </xsl:when>
       <xsl:otherwise>
         <xsl:if test="$warn.no.programlisting.canvas.dimension">
-          <xsl:message>programlisting: defaulting width to 500</xsl:message>
+          <xsl:message>programlisting: defaulting width to 100%</xsl:message>
         </xsl:if>
-        <xsl:text>500</xsl:text>
+        <xsl:text>100%</xsl:text>
       </xsl:otherwise>
     </xsl:choose>
   </xsl:template>