[Laszlo-checkins] r13574 - in openlaszlo/branches/4.3: . WEB-INF/lps/lfc/kernel/dhtml
ptw@openlaszlo.org
ptw at openlaszlo.org
Wed Apr 1 13:19:47 PDT 2009
Author: ptw
Date: 2009-04-01 13:19:43 -0700 (Wed, 01 Apr 2009)
New Revision: 13574
Modified:
openlaszlo/branches/4.3/
openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
Log:
Merged revisions 13573 via svnmerge from
http://svn.openlaszlo.org/openlaszlo/trunk
.......
r13573 | hqm | 2009-04-01 15:56:06 -0400 (Wed, 01 Apr 2009) | 35 lines
Change 20090401-hqm-x by hqm at badtzmaru.home on 2009-04-01 15:16:59 EDT
in /Users/hqm/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: fix for clickable text DHTML bug
New Features:
Bugs Fixed: LPP-8007
Technical Reviewer: ptw
QA Reviewer: a.bargull
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
+ use a CSS style for the text click div classes which does not have "overflow=hidden" set.
+ created a parallel set of CSS classes, named "lz*textcontainer_click", to be used in the
click div hierarchy
Question: do we really need the overflow=hidden in the lztext CSS classes? It seemed to risky
to remove them right before a release.
Tests:
+ test case from bug
+ calendar DHTML
+ amazon DHTML
.......
Property changes on: openlaszlo/branches/4.3
___________________________________________________________________
Name: svnmerge-integrated
- /openlaszlo/branches/4.1:1-10153 /openlaszlo/branches/4.2:1-12154,12181,13205 /openlaszlo/branches/devildog:1-8432 /openlaszlo/branches/pagan-deities:1-7955,8825,10756-10920,10922-10928,10930-10935,11151,11207,11554,13476 /openlaszlo/branches/paperpie:1-6504,6506-6574,6576-7135,7137-7235 /openlaszlo/branches/wafflecone:1-5746,5818-6068,6070-6205,6207-6213,6216-6265,6267-6368,6370-6431,6433-6450,6497,6509,6661,7097,7872 /openlaszlo/trunk:1-13548,13554,13557,13559,13562,13566
+ /openlaszlo/branches/4.1:1-10153 /openlaszlo/branches/4.2:1-12154,12181,13205 /openlaszlo/branches/devildog:1-8432 /openlaszlo/branches/pagan-deities:1-7955,8825,10756-10920,10922-10928,10930-10935,11151,11207,11554,13476 /openlaszlo/branches/paperpie:1-6504,6506-6574,6576-7135,7137-7235 /openlaszlo/branches/wafflecone:1-5746,5818-6068,6070-6205,6207-6213,6216-6265,6267-6368,6370-6431,6433-6450,6497,6509,6661,7097,7872 /openlaszlo/trunk:1-13548,13554,13557,13559,13562,13566,13573
Modified: openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
===================================================================
--- openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js 2009-04-01 19:56:06 UTC (rev 13573)
+++ openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js 2009-04-01 20:19:43 UTC (rev 13574)
@@ -19,7 +19,7 @@
this.__LZdiv.owner = this;
if (this.quirks.fix_clickable) {
this.__LZclickcontainerdiv = document.createElement('div');
- this.__LZclickcontainerdiv.className = 'lzinputtextcontainer';
+ this.__LZclickcontainerdiv.className = 'lzinputtextcontainer_click';
this.__LZclickcontainerdiv.owner = this;
}
if ($debug) {
@@ -102,7 +102,7 @@
}
if (this.quirks.fix_clickable) {
// The click container has to match the div style
- this.__LZclickcontainerdiv.className = this.__LZdiv.className;
+ this.__LZclickcontainerdiv.className = this.__LZdiv.className+"_click";
}
if (this.quirks.firefox_autocomplete_bug) {
lz.embed.__setAttr(this.__LzInputDiv, 'autocomplete', 'off');
Modified: openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
===================================================================
--- openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js 2009-04-01 19:56:06 UTC (rev 13573)
+++ openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js 2009-04-01 20:19:43 UTC (rev 13574)
@@ -228,6 +228,20 @@
paddingBottom: '2px',
paddingLeft: '2px'
},
+ // TODO [hqm 2009-04] This is a duplicate of lztextcontainer
+ // above, but without overflow='hidden', as a fix for
+ // LPP-8007. Question, why did we need overflow='hidden' in
+ // lztextcontainer in the first place? would it be safe to just
+ // remove it there, and not have to have this parallel
+ // lztextcontainer style?
+ lztextcontainer_click: {
+ position: 'absolute',
+ // To create swf textfield 'gutter'
+ paddingTop: '2px',
+ paddingRight: '2px',
+ paddingBottom: '2px',
+ paddingLeft: '2px'
+ },
lzinputtextcontainer: {
position: 'absolute',
overflow: 'hidden',
@@ -237,6 +251,14 @@
paddingBottom: '4px',
paddingLeft: '1px'
},
+ // TODO [hqm 2009-04] This is a duplicate of lzinputtextcontainer (see above)
+ lzinputtextcontainer_click: {
+ position: 'absolute',
+ paddingTop: '0px',
+ paddingRight: '3px',
+ paddingBottom: '4px',
+ paddingLeft: '1px'
+ },
lzinputtextmultilinecontainer: {
position: 'absolute',
overflow: 'hidden',
@@ -246,6 +268,14 @@
paddingBottom: '3px',
paddingLeft: '1px'
},
+ // TODO [hqm 2009-04] This is a duplicate of lzinputtextmultilinecontainer (see above)
+ lzinputtextmultilinecontainer_click: {
+ position: 'absolute',
+ paddingTop: '1px',
+ paddingRight: '3px',
+ paddingBottom: '3px',
+ paddingLeft: '1px'
+ },
lztext: {
fontFamily: 'Verdana,Vera,sans-serif',
fontStyle: 'normal',
Modified: openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
===================================================================
--- openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js 2009-04-01 19:56:06 UTC (rev 13573)
+++ openlaszlo/branches/4.3/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js 2009-04-01 20:19:43 UTC (rev 13574)
@@ -29,7 +29,7 @@
this.__LZdiv.owner = this;
if (this.quirks.fix_clickable) {
this.__LZclickcontainerdiv = document.createElement('div');
- this.__LZclickcontainerdiv.className = 'lztextcontainer';
+ this.__LZclickcontainerdiv.className = 'lztextcontainer_click';
this.__LZclickcontainerdiv.owner = this;
}
if ($debug) {
More information about the Laszlo-checkins
mailing list