[Laszlo-checkins] r13573 - openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml

[hqm@openlaszlo.org]

Author: hqm
Date: 2009-04-01 12:56:06 -0700 (Wed, 01 Apr 2009)
New Revision: 13573

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
   openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
   openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
Log:
Change 20090401-hqm-x by hqm at badtzmaru.home on 2009-04-01 15:16:59 EDT
    in /Users/hqm/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary:  fix for clickable text DHTML bug

New Features:

Bugs Fixed: LPP-8007

Technical Reviewer: ptw
QA Reviewer: a.bargull
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

+ use a CSS style for the text click div classes which does not have "overflow=hidden" set.

+ created a parallel set of CSS classes, named "lz*textcontainer_click", to be used in the
click div hierarchy

Question: do we really need the overflow=hidden in the lztext CSS classes? It seemed to risky
to remove them right before a release. 

Tests:

+ test case from bug
+ calendar DHTML
+ amazon DHTML



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js	2009-04-01 19:21:38 UTC (rev 13572)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js	2009-04-01 19:56:06 UTC (rev 13573)
@@ -19,7 +19,7 @@
     this.__LZdiv.owner = this;
     if (this.quirks.fix_clickable) {
         this.__LZclickcontainerdiv = document.createElement('div');
-        this.__LZclickcontainerdiv.className = 'lzinputtextcontainer';
+        this.__LZclickcontainerdiv.className = 'lzinputtextcontainer_click';
         this.__LZclickcontainerdiv.owner = this;
     }    
     if ($debug) {
@@ -102,7 +102,7 @@
     }
     if (this.quirks.fix_clickable) {
         // The click container has to match the div style
-        this.__LZclickcontainerdiv.className = this.__LZdiv.className;
+        this.__LZclickcontainerdiv.className = this.__LZdiv.className+"_click";
     }
     if (this.quirks.firefox_autocomplete_bug) {
         lz.embed.__setAttr(this.__LzInputDiv, 'autocomplete', 'off');

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js	2009-04-01 19:21:38 UTC (rev 13572)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js	2009-04-01 19:56:06 UTC (rev 13573)
@@ -228,6 +228,20 @@
         paddingBottom: '2px',
         paddingLeft: '2px'
     },
+    // TODO [hqm 2009-04] This is a duplicate of lztextcontainer
+    // above, but without overflow='hidden', as a fix for
+    // LPP-8007. Question, why did we need overflow='hidden' in
+    // lztextcontainer in the first place?  would it be safe to just
+    // remove it there, and not have to have this parallel
+    // lztextcontainer style?
+    lztextcontainer_click: {
+        position: 'absolute',
+        // To create swf textfield 'gutter'
+        paddingTop: '2px',
+        paddingRight: '2px',
+        paddingBottom: '2px',
+        paddingLeft: '2px'
+    },
     lzinputtextcontainer: {
         position: 'absolute',
         overflow: 'hidden',
@@ -237,6 +251,14 @@
         paddingBottom: '4px',
         paddingLeft: '1px'
     },
+    // TODO [hqm 2009-04] This is a duplicate of lzinputtextcontainer (see above)
+    lzinputtextcontainer_click: {
+        position: 'absolute',
+        paddingTop: '0px',
+        paddingRight: '3px',
+        paddingBottom: '4px',
+        paddingLeft: '1px'
+    },
     lzinputtextmultilinecontainer: {
         position: 'absolute',
         overflow: 'hidden',
@@ -246,6 +268,14 @@
         paddingBottom: '3px',
         paddingLeft: '1px'
     },
+    // TODO [hqm 2009-04] This is a duplicate of lzinputtextmultilinecontainer (see above)
+    lzinputtextmultilinecontainer_click: {
+        position: 'absolute',
+        paddingTop: '1px',
+        paddingRight: '3px',
+        paddingBottom: '3px',
+        paddingLeft: '1px'
+    },
     lztext: {
         fontFamily: 'Verdana,Vera,sans-serif',
         fontStyle: 'normal',

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js	2009-04-01 19:21:38 UTC (rev 13572)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js	2009-04-01 19:56:06 UTC (rev 13573)
@@ -29,7 +29,7 @@
     this.__LZdiv.owner = this;
     if (this.quirks.fix_clickable) {
         this.__LZclickcontainerdiv = document.createElement('div');
-        this.__LZclickcontainerdiv.className = 'lztextcontainer';
+        this.__LZclickcontainerdiv.className = 'lztextcontainer_click';
         this.__LZclickcontainerdiv.owner = this;
     }    
     if ($debug) {