[Laszlo-checkins] r10933 - in openlaszlo/trunk: WEB-INF/lps/lfc/core WEB-INF/lps/lfc/data WEB-INF/lps/lfc/helpers WEB-INF/lps/server/bin lps/components/base lps/components/charts/common lps/components/extensions lps/components/extensions/test lps/components/incubator
pbr@openlaszlo.org
pbr at openlaszlo.org
Tue Sep 9 13:23:20 PDT 2008
Author: pbr
Date: 2008-09-09 13:23:10 -0700 (Tue, 09 Sep 2008)
New Revision: 10933
Modified:
openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataText.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs
openlaszlo/trunk/WEB-INF/lps/server/bin/convert_setters.pl
openlaszlo/trunk/lps/components/base/basedatacombobox.lzx
openlaszlo/trunk/lps/components/base/basegrid.lzx
openlaszlo/trunk/lps/components/charts/common/dataseries.lzx
openlaszlo/trunk/lps/components/extensions/html.lzx
openlaszlo/trunk/lps/components/extensions/test/html.lzx
openlaszlo/trunk/lps/components/incubator/autocompletecombobox.lzx
openlaszlo/trunk/lps/components/incubator/libflickr.lzx
Log:
Change 20080909-Philip-8 by Philip at Philip-DC on 2008-09-09 11:55:36 EDT
in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Fix setters in remainder of LFC and components
New Features:
Bugs Fixed: LPP-5644 (partial)
Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
This changeset fixes the rest of the LFC setters to use the new format. There are 2 exceptions. LzDataPath.setOrder and LzDataSet.setData take 2 arguments so they remain the primary code path.
I modified convert_setters.pl to check which methods are defined in a file. The script will not change any names that collides with the list of LFC setteers. It will warn instead to manually check the file.
The next changeset will update examples and demos.
Tests:
lzpix, component sampler, smokecheck run fine.
Files:
M WEB-INF/lps/lfc/core/LzNode.lzs
M WEB-INF/lps/lfc/helpers/LzCommand.lzs
M WEB-INF/lps/lfc/data/LzReplicationManager.lzs
M WEB-INF/lps/lfc/data/LzDataText.lzs
M WEB-INF/lps/lfc/data/LzDataset.lzs
M WEB-INF/lps/lfc/data/LzDatapath.lzs
M WEB-INF/lps/server/bin/convert_setters.pl
M lps/components/charts/common/dataseries.lzx
M lps/components/incubator/autocompletecombobox.lzx
M lps/components/incubator/libflickr.lzx
M lps/components/extensions/test/html.lzx
M lps/components/extensions/html.lzx
M lps/components/base/basegrid.lzx
M lps/components/base/basedatacombobox.lzx
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080909-Philip-8.tar
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs 2008-09-09 20:23:10 UTC (rev 10933)
@@ -458,6 +458,19 @@
*/
var datapath = null;
+ /**
+ * Setter for datapath
+ * @access private
+ */
+ function $lzc$set_datapath (dp) {
+ if (null != this.datapath && dp != LzNode._ignoreAttribute) {
+ this.datapath.setXPath(dp);
+ } else {
+ // LzDatapath will set datapath of its immediateparent
+ new LzDatapath ( this, { xpath : dp } );
+ }
+ }
+
/** The execution of a <class>node</class>'s <method>init</method> method and
* sending of the <event>oninit</event> event is under the control
* of its <attribute>initstage</attribute> attribute, as follows:
@@ -1643,20 +1656,9 @@
* @deprecated Use setAttribute('datapath', ...) instead.
*/
function setDatapath ( dp ) {
- if (null != this.datapath && dp != LzNode._ignoreAttribute) {
- this.datapath.setXPath(dp);
- } else {
- // LzDatapath will set datapath of its immediateparent
- new LzDatapath ( this, { xpath : dp } );
- }
+ if ($debug) Debug.deprecated(this, arguments.callee, this.setAttribute);
+ this.$lzc$set_datapath(dp);
}
- /**
- * Setter for datapath
- * @access private
- */
- function $lzc$set_datapath (dp) {
- this.setDatapath(dp);
- }
/**
* Sets the datacontext for the node to the data element given as an
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataText.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataText.lzs 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataText.lzs 2008-09-09 20:23:10 UTC (rev 10933)
@@ -45,8 +45,17 @@
var data :String = "";
/** @access private */
-function $lzc$set_data(v:String) :void { this.setData(v); }
+function $lzc$set_data(newdata:String) :void {
+ this.data = newdata;
+ if (this.ondata && this.ondata.ready) {
+ this.ondata.sendEvent( newdata );
+ }
+ if (this.ownerDocument) {
+ this.ownerDocument.handleDocumentChange( "data", this, 1 );
+ }
+}
+
/** @type Number
* @keywords read-only
*/
@@ -58,13 +67,8 @@
* @deprecated Use setAttribute('data', ...) instead.
*/
public function setData ( newdata:String ) {
- this.data = newdata;
- if (this.ondata && this.ondata.ready) {
- this.ondata.sendEvent( newdata );
- }
- if (this.ownerDocument) {
- this.ownerDocument.handleDocumentChange( "data", this, 1 );
- }
+ if ($debug) Debug.deprecated(this, arguments.callee, this.setAttribute);
+ this.$lzc$set_data(newdata);
}
/**
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs 2008-09-09 20:23:10 UTC (rev 10933)
@@ -187,7 +187,7 @@
* @param String xpath: An XPath giving the value to use for comparison.
* @param Function|String comparator: See the <param>comparator</param>
* parameter of <method>setComparator</method> for details.
- * @deprecated Use setAttribute('order', ...) instead.
+ * @deprecated Use setAttribute('sortpath', ...) instead when no comparator specified.
*
* @access private
*/
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs 2008-09-09 20:23:10 UTC (rev 10933)
@@ -262,7 +262,12 @@
*/
var src = null;
/** @access private */
-function $lzc$set_src(v) { this.setSrc(v); }
+function $lzc$set_src(src) {
+ this.src = src;
+ if ( this.autorequest ){
+ this.doRequest() ;
+ }
+}
/** If autorequest is true, a new request will be issued automatically when the source or query params are modified.
@@ -272,7 +277,9 @@
var autorequest = false;
/** @access private */
-function $lzc$set_autorequest(v) { this.setAutorequest(v); }
+function $lzc$set_autorequest(b) {
+ this.autorequest = b;
+}
/** If true, the datset will make a request when it
* inits. The default for this is false.
@@ -281,7 +288,14 @@
*/
var request = false;
/** @access private */
-function $lzc$set_request(v) { this.setRequest(v); }
+function $lzc$set_request(b) {
+ this.request = b;
+ if ( ! b ) return;
+ if ( !this.isinited ){
+ this.reqOnInitDel = new LzDelegate( this , "doRequest" ,
+ this, "oninit" );
+ }
+}
/** @access private */
var headers = null;
@@ -449,7 +463,7 @@
* Sets the data for the dataset
* @param data a LzDataElement or list of Elements
* @param headers optional HTTP response headers
- * @deprecated Use setAttribute('data', ...) instead.
+ * @deprecated Use setAttribute('data', ...) instead when headers is not specified.
* @access private
*/
override function setData( data , headers = null ) {
@@ -560,10 +574,8 @@
*/
function setSrc( src ) {
- this.src = src;
- if ( this.autorequest ){
- this.doRequest() ;
- }
+ if ($debug) Debug.deprecated(this, arguments.callee, this.setAttribute);
+ this.$lzc$set_src(src);
}
/**
@@ -592,12 +604,8 @@
* @deprecated Use setAttribute('request', ...) instead.
*/
function setRequest( b ) {
- this.request = b;
- if ( ! b ) return;
- if ( !this.isinited ){
- this.reqOnInitDel = new LzDelegate( this , "doRequest" ,
- this, "oninit" );
- }
+ if ($debug) Debug.deprecated(this, arguments.callee, this.setAttribute);
+ this.$lzc$set_request(b);
}
/**
@@ -811,7 +819,8 @@
* @deprecated Use setAttribute('autorequest', ...) instead.
*/
function setAutorequest(b) {
- this.autorequest = b;
+ if ($debug) Debug.deprecated(this, arguments.callee, this.setAttribute);
+ this.$lzc$set_autorequest(b);
}
/**
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs 2008-09-09 20:23:10 UTC (rev 10933)
@@ -700,11 +700,6 @@
* @deprecated Use setAttribute('datapath', ...) instead.
* @access private
*/
-override function setDatapath ( xp ){
- this.setXPath( xp );
-}
-
-/** @access private */
override function $lzc$set_datapath(v) :void {
this.setXPath(v);
}
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzCommand.lzs 2008-09-09 20:23:10 UTC (rev 10933)
@@ -52,7 +52,10 @@
*/
var keys = null;
/** @access private */
-function $lzc$set_key(v) { this.setKeys(v); }
+function $lzc$set_key(k) {
+ this.keys = k;
+ lz.Keys.callOnKeyCombo( this , k );
+}
/**
* If the command is active, this event is sent
@@ -73,8 +76,8 @@
* @deprecated Use setAttribute('key', ...) instead.
*/
function setKeys ( k ){
- this.keys = k;
- lz.Keys.callOnKeyCombo( this , k );
+ if ($debug) Debug.deprecated(this, arguments.callee, this.setAttribute);
+ this.$lzc$set_key(k);
}
/**
Modified: openlaszlo/trunk/WEB-INF/lps/server/bin/convert_setters.pl
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/server/bin/convert_setters.pl 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/WEB-INF/lps/server/bin/convert_setters.pl 2008-09-09 20:23:10 UTC (rev 10933)
@@ -22,32 +22,6 @@
# Adapated from convert_required.pl by Don Anderson
-################
-# Conversions:
-#
-# On script lines that contain references to classes such
-# as LzAudio, LzBrowser, ... (the complete list is in
-# convert_class_name_changes()):
-#
-# - change the name from Lz<name> to lz.<name>
-#
-# On script lines that are of the form 'new classname...' or
-# 'instanceof classname...':
-#
-# - if classname already has lz. , no change
-#
-# - if classname is a class/interface defined in one of the input
-# files (e.g. via <class name="classname"...), then
-# change to new lz.classname (or instanceof lz.classname).
-#
-# - if classname is class for a LFC tagname, convert it to tagname
-# and add lz. (new LzView => lz.view)
-#
-# - new global[...] is converted to new lz[...]
-#
-# - otherwise, no change (this includes Object, Array, ...).
-#
-
use File::Basename;
use File::Copy;
use Getopt::Std;
@@ -67,6 +41,8 @@
for each file changed, invoke the graphical difftool,
and prompt the user to keep or not keep the changes
+ -q
+ Quiet mode. Only display files that have been modified.
-t
create output for simple tests in /tmp/convtest
@@ -90,6 +66,7 @@
##
my $DEBUGLEVEL=0; # set to non-zero to get successive amounts of debug out
my $curfile = "unknown file"; # track current file for error messages
+my $quietmode=undef; # Set to a vlue to run quietly.
# Mapping of old setter to attribute name
my %settername = (
@@ -137,24 +114,64 @@
'setSharpness' => 'sharpness',
'setThickness' => 'thickness',
# lz.inputtext
- 'setEnabled' => 'enabled'
+ 'setEnabled' => 'enabled',
+# lz.animator
+ 'setMotion' => 'motion',
+ 'setTo' => 'to',
+# lz.animatorgroup
+ 'setTarget' => 'target',
+ 'setDuration' => 'duration',
+# lz.node
+ 'setDatapath' => 'datapath', # Also used in LzReplicationManager
+# lz.dataset
+ # 'setData' => 'data', # Used in dataset/datatext but 2 args in dataset
+ 'setSrc' => 'src',
+ 'setRequest' => 'request',
+ 'setAutorequest' => 'autorequest',
+# lz.command
+ 'setKeys' => 'key'
);
+# Search an array for the string and returns 1 if found. Else undef
+# search_array($arrayref, $string)
+sub search_array
+{
+ my ($arrayref, $string) = @_;
+ return undef unless defined($arrayref);
+
+ foreach my $s (@$arrayref) {
+ if ($s eq $string) {
+ return 1;
+ }
+ }
+
+ return undef;
+}
+
+
+# initialize_substitutions(\@ignore)
+#
# Take the information from %settername and construct a hash with the
# actual substitutions to make.
# replace '.setter(' with 'setAttribute( 'attribute', '
# replace '.setter (' with 'setAttribute( 'attribute', '
+#
+# If an arrayref is supplied, these setter names are not overridden in the
+# file. This reduces the chance of making a mistake.
my %substitutions = ();
sub initialize_substitutions
{
- my $size = scalar keys %substitutions;
- if ($size > 0) {
- return;
- }
+ my $ignore = shift(@_);
+ %substitutions = ();
while (my ($setter, $attribute) = each(%settername)) {
+ # Don't process setters in our ignore list
+ if (defined search_array($ignore, $setter)) {
+ next;
+ }
+
# We replace '.setter(' or '.setter ('
my $setter1 = "\\.$setter\\s*\\(\\s*";
my $replacement = ".setAttribute('$attribute', ";
@@ -247,6 +264,17 @@
}
}
+# Compares two array refs of strings. Returns 1 if equal, 0 if not equal
+sub compare_arrays {
+ my ($ref1, $ref2) = @_;
+ return 0 unless @$ref1 == @$ref2;
+ for (my $i=0; $i<@$ref1; $i++) {
+ return 0 if $ref1->[$i] ne $ref2->[$i];
+ }
+ return 1;
+}
+
+
##
# convert_file(filename)
# Do all conversions for the file.
@@ -257,23 +285,49 @@
my $event;
my $name;
- # Make sure the substitutions are initialized
- initialize_substitutions ();
-
debugentry(1, "convert_file", @_);
$curfile = $file;
+ if (!defined $quietmode && -f "$file.bak") {
+ print "WARNING: Skipping $file because $file.bak already exists\n";
+ return;
+ }
copy("$file", "$file.bak") || die("Cannot copy to $file.bak");
-
+
# Read the entire file, process it, and write it back
open(IN, "<$file") || die("Cannot open $file");
my @lines=<IN>;
close(IN);
+ my @orig = @lines;
+
+ # Get the list of method names defined in this file. Warn the user if these
+ # names conflict with our stored names
+ my @methods = ();
+ my @ignore = ();
+ foreach my $line (@lines) {
+ if ($line =~ /\<method.*name=\"(.*?)\".*\>/) {
+ push @methods, $1;
+ }
+ # Catch this: lz.embed.iframemanager.setSrc = function(...)
+ elsif ($line =~ /.+\.(.+?)\s*\=\s*function/) {
+ push @methods, $1;
+ }
+ }
+ foreach my $method (@methods) {
+ if (exists $settername{$method}) {
+ push @ignore, $method;
+ print "WARNING. Possible Conflict: The method '$method' in $file will not be converted by this script because of a possible name collision. Calls to '$method' are normally converted to setAttribute by this script. Please check this file manually.\n";
+ }
+ }
+
+ # Make sure the substitutions are initialized
+ initialize_substitutions (\@ignore);
+
# If the file contains any attribute setters, tell the user to manually
# check it
my $contents = join("\n", @lines);
- if ($contents =~ /setter\s*=\s*['"]/) {
- print "$file contains attribute setters. Please check these files manually\n";
+ if ($contents =~ /setter\s*=\s*\"\s*setAttribute\s*\"/) {
+ print "$file might contain a recursive attribute setters. Please check this file manually\n";
}
# Do each of the substitutions listed in %substitutions
@@ -282,6 +336,14 @@
map(s/$orig/$replacement/g, @lines);
}
+ if (compare_arrays(\@orig, \@lines) == 1) {
+ # No change made to file. Don't write anything
+ if (!defined $quietmode) {
+ print "No changes to '$file'. Skipping\n";
+ }
+ return;
+ }
+
# Second, convert the files
unlink("$file.tmp");
open(OUT, ">$file.tmp") || die("Cannot create $file.tmp");
@@ -298,7 +360,7 @@
##
my $file;
my %options;
-$ok = getopts("d:tx:vg:", \%options);
+$ok = getopts("qd:tx:vg:", \%options);
if (!$ok) {
print STDERR "$USAGE";
exit(1);
@@ -311,6 +373,10 @@
exit(0);
}
+if ($options{q}) {
+ $quietmode = 1;
+}
+
if ($options{t}) {
# create_test("/tmp/convtest");
# convert_file("/tmp/convtest");
@@ -332,12 +398,6 @@
}
foreach $file (@ARGV) {
- if (! -f $file) {
- }
- file_cannot_exist("$file.bak");
-}
-
-foreach $file (@ARGV) {
if (! -f $file ) {
print STDERR "$PROG: $file does not exist, skipping\n";
}
Modified: openlaszlo/trunk/lps/components/base/basedatacombobox.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/basedatacombobox.lzx 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/lps/components/base/basedatacombobox.lzx 2008-09-09 20:23:10 UTC (rev 10933)
@@ -309,7 +309,7 @@
itd = "local:" + "parent.owner." + itd.substring( 6 );
}
- cblist.item.setDatapath(itd);
+ cblist.item.setAttribute('datapath', itd);
cblist.setAttribute('attach', this.listattach);
if (this._selectdel == null) {
Modified: openlaszlo/trunk/lps/components/base/basegrid.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/basegrid.lzx 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/lps/components/base/basegrid.lzx 2008-09-09 20:23:10 UTC (rev 10933)
@@ -138,7 +138,7 @@
<method name="setContentdatapath" args="cdp" >
if (this.isinited) {
- this._getReplicator().setDatapath( cdp );
+ this._getReplicator().setAttribute('datapath', cdp );
}
this.contentdatapath = cdp;
if (this["oncontentdatapath"]) {
@@ -367,7 +367,7 @@
if ( ! this.datapath ) {
haddatapath = false;
var ovisibility = this.visibility;
- this.setDatapath( "." );
+ this.setAttribute('datapath', "." );
this.datapath.setAttribute( "datacontrolsvisibility",
false );
this.setAttribute('visibility', ovisibility );
Modified: openlaszlo/trunk/lps/components/charts/common/dataseries.lzx
===================================================================
--- openlaszlo/trunk/lps/components/charts/common/dataseries.lzx 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/lps/components/charts/common/dataseries.lzx 2008-09-09 20:23:10 UTC (rev 10933)
@@ -140,7 +140,7 @@
this.values[i] = this.processData(this.values[i]);
}
}
- this.dataview.setDatapath(this.columndatapath);
+ this.dataview.setAttribute('datapath', this.columndatapath);
}
]]>
Modified: openlaszlo/trunk/lps/components/extensions/html.lzx
===================================================================
--- openlaszlo/trunk/lps/components/extensions/html.lzx 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/lps/components/extensions/html.lzx 2008-09-09 20:23:10 UTC (rev 10933)
@@ -56,11 +56,11 @@
<attribute name="ready" value="false"/>
<attribute name="history" value="true"/>
- <attribute name="target" value="null" setter="this.setTarget(target)"/>
+ <attribute name="target" value="null"/>
<attribute name="framename" value="" type="string"/>
<event name="onload"/>
<event name="onready"/>
- <method name="setTarget" args="t">
+ <setter name="target" args="t">
if (t == null) return;
this.target = t;
if (this['_posdel']) {
@@ -75,18 +75,18 @@
//Debug.write(t);
this.__updatepos(null);
if (this['ontarget']) this.ontarget.sendEvent(t);
- </method>
+ </setter>
- <attribute name="visible" type="expression" value="true" setter="setVisible(visible)"/>
- <method name="setVisible" args="v">
+ <attribute name="visible" type="expression" value="true"/>
+ <setter name="visible" args="v">
this.visible = v;
if (this['iframeid']) lz.embed.iframemanager.setVisible(this.iframeid, v);
if (this['onvisible']) this.onvisible.sendEvent(v);
- </method>
+ </setter>
- <attribute name="src" type="text" setter="this.setSrc(src)"/>
+ <attribute name="src" type="text"/>
<event name="onsrc"/>
- <method name="setSrc" args="s">
+ <setter name="src" args="s">
this.src = s;
this.setAttribute('loading', true);
if (this['iframeid']) {
@@ -95,7 +95,7 @@
this.srcset = s;
}
this.onsrc.sendEvent(s);
- </method>
+ </setter>
<!--- @access private -->
<handler name="oninit">
Modified: openlaszlo/trunk/lps/components/extensions/test/html.lzx
===================================================================
--- openlaszlo/trunk/lps/components/extensions/test/html.lzx 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/lps/components/extensions/test/html.lzx 2008-09-09 20:23:10 UTC (rev 10933)
@@ -21,7 +21,7 @@
<handler name="onclick">
if (classroot.main) {
classroot.main.setAttribute('visible', false);
- classroot.main.setSrc('');
+ classroot.main.setAttribute('src', '');
}
</handler>
</button>
Modified: openlaszlo/trunk/lps/components/incubator/autocompletecombobox.lzx
===================================================================
--- openlaszlo/trunk/lps/components/incubator/autocompletecombobox.lzx 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/lps/components/incubator/autocompletecombobox.lzx 2008-09-09 20:23:10 UTC (rev 10933)
@@ -32,7 +32,7 @@
this.setAttribute("__component_contents",[]);
Debug.write("autocompletecombobox got datapath = ",this.datapath.xpath);
Debug.write("The float box : ",myFloatBox);
- myFloatBox.setDatapath(this.datapath.xpath);
+ myFloatBox.setAttribute('datapath', this.datapath.xpath);
</handler>
<method name="showAll">
@@ -177,7 +177,7 @@
<handler name="ondata">
Debug.write("floatinglist got data = ",this.data);
var childXPath = this.datapath.xpath + "/"+owner.contentpath;
- this.replicated_textitem.setDatapath(childXPath);
+ this.replicated_textitem.setAttribute('datapath', childXPath);
</handler>
<textlistitem name="replicated_textitem" datapath="">
Modified: openlaszlo/trunk/lps/components/incubator/libflickr.lzx
===================================================================
--- openlaszlo/trunk/lps/components/incubator/libflickr.lzx 2008-09-09 20:22:46 UTC (rev 10932)
+++ openlaszlo/trunk/lps/components/incubator/libflickr.lzx 2008-09-09 20:23:10 UTC (rev 10933)
@@ -92,7 +92,7 @@
var api_sig_string=gGlobals.SHAREDSECRET;
// set source
- ds.setSrc(gGlobals.RESTSRC);
+ ds.setAttribute('src', gGlobals.RESTSRC);
// add api_key
argobjarr.push({argname:"api_key", argvalue:apikey});
More information about the Laszlo-checkins
mailing list