[Laszlo-checkins] r10893 - openlaszlo/branches/pagan-deities/WEB-INF/lps/lfc/profiler

ptw@openlaszlo.org ptw at openlaszlo.org
Fri Sep 5 13:13:39 PDT 2008


Author: ptw
Date: 2008-09-05 13:13:37 -0700 (Fri, 05 Sep 2008)
New Revision: 10893

Modified:
   openlaszlo/branches/pagan-deities/WEB-INF/lps/lfc/profiler/LzProfile.lzs
Log:
Change 20080905-ptw-4 by ptw at dueling-banjos.local on 2008-09-05 16:06:05 EDT
    in /Users/ptw/OpenLaszlo/pagan-deities
    for http://svn.openlaszlo.org/openlaszlo/branches/pagan-deities

Summary: Comment out debug statements

Bugs Fixed:
LPP-6867:  Profiler returns confusing results

Technical Reviewer: hminsky (pending)
QA Reviewer: pkang (pending)

Details:
    Comment out debug statements, remove unused code

Tests:
    Inspection



Modified: openlaszlo/branches/pagan-deities/WEB-INF/lps/lfc/profiler/LzProfile.lzs
===================================================================
--- openlaszlo/branches/pagan-deities/WEB-INF/lps/lfc/profiler/LzProfile.lzs	2008-09-05 20:00:23 UTC (rev 10892)
+++ openlaszlo/branches/pagan-deities/WEB-INF/lps/lfc/profiler/LzProfile.lzs	2008-09-05 20:13:37 UTC (rev 10893)
@@ -260,7 +260,7 @@
                 this.returnval = new LoadVars();
                 // callback from Flash LoadVars.sendAndLoad()
                 this.returnval.onLoad = function () {
-                  Debug.write('open--', 'socket:', Profiler.socketState, 'data:', Profiler.dataState);
+//                   if ($debug) Debug.write('open--', 'socket:', Profiler.socketState, 'data:', Profiler.dataState);
                   Profiler.socketState = 'open';
                 };
                 lv.sendAndLoad(nurl, this.returnval, "POST");
@@ -277,54 +277,23 @@
                 this.openTag('xml');
                 this.write('\n');
             } else {
-                Debug.error("Profiler.connect: Unsupported runtime %s", $runtime);
+              if ($debug) Debug.error("Profiler.connect: Unsupported runtime %s", $runtime);
             }
         } else {
-            Debug.error("Profiler.connect: Could not connect: %s", why);
+          if ($debug) Debug.error("Profiler.connect: Could not connect: %s", why);
         }
     }
     return this.socket;
   },
 
-    flashOnLoadHandler: function (success) {
-      // Right now, the server is always returning an error
-      // All we care is that we heard back from the server
-//       if (success) {
-        Debug.info("sendAndLoad returned: %s", this.returnval);
-        switch (this.dataState) {
-          case 'writing':
-            delete this.writeBuffer;
-            // fall through
-          case 'opening':
-            this.dataState = 'idle';
-            break;
-          case 'closing':
-            if (! this.dump()) {
-              this.dataState = 'closed';
-              this.closed();
-            }
-            break;
-          case 'closed':
-            // Success!
-            break;
-          default:
-            Debug.error("Unknown data state %w", this.DataState);
-            this.dataState = 'error';
-        }
-//       } else {
-//         Debug.error("sendAndLoad returned: %s", this.returnval);
-//         this.dataState = 'error';
-//       }
-    },
-
     processSocketChange: function () {
       var sock = this.socket;
       if (sock) {
         if (sock.readyState == 4) {
           if (sock.status == 200) {
-//             Debug.info("Profiler.processSocketChange: %s %s", sock.statusText, sock.responseText);
+//             if ($debug) Debug.info("Profiler.processSocketChange: %s %s", sock.statusText, sock.responseText);
           } else {
-            Debug.error("Profiler.processSocketChange: %s %s", sock.statusText, sock.responseText);
+            if ($debug) Debug.error("Profiler.processSocketChange: %s %s", sock.statusText, sock.responseText);
           }
         }
       }
@@ -444,7 +413,7 @@
                     this.returnval = new LoadVars();
                     // callback from Flash LoadVars.sendAndLoad()
                     this.returnval.onLoad = function () {
-                      Debug.write('data--', 'socket:', Profiler.socketState, 'data:', Profiler.dataState);
+//                       if ($debug) Debug.write('data--', 'socket:', Profiler.socketState, 'data:', Profiler.dataState);
                       Profiler.dataState = 'idle';
                       delete Profiler.writeBuffer;
                       // Check for more
@@ -513,7 +482,7 @@
             this.returnval = new LoadVars();
             // callback from Flash LoadVars.sendAndLoad()
             this.returnval.onLoad = function () {
-              Debug.write('closed--', 'socket:', Profiler.socketState, 'data:', Profiler.dataState);
+//               if ($debug) Debug.write('closed--', 'socket:', Profiler.socketState, 'data:', Profiler.dataState);
               Profiler.socketState = 'closed';
               delete Profiler.socket;
             };



More information about the Laszlo-checkins mailing list