[Laszlo-checkins] r10866 - openlaszlo/trunk/lps/components/base

bargull@openlaszlo.org bargull at openlaszlo.org
Wed Sep 3 15:03:04 PDT 2008


Author: bargull
Date: 2008-09-03 15:03:01 -0700 (Wed, 03 Sep 2008)
New Revision: 10866

Modified:
   openlaszlo/trunk/lps/components/base/basecomponent.lzx
   openlaszlo/trunk/lps/components/base/basedatacombobox.lzx
Log:
Change 20080903-bargull-QOI by bargull at dell--p4--2-53 on 2008-09-03 21:42:30
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix component warnings

New Features:

Bugs Fixed: LPP-6919, LPP-6921

Technical Reviewer: pbr
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
- added ignore-argument to fix delegate-warning (LPP-6919)
- set property to null, instead of deleting it, to avoid "undefined property warning" (LPP-6921)
    

Tests:



Modified: openlaszlo/trunk/lps/components/base/basecomponent.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/basecomponent.lzx	2008-09-03 19:44:30 UTC (rev 10865)
+++ openlaszlo/trunk/lps/components/base/basecomponent.lzx	2008-09-03 22:03:01 UTC (rev 10866)
@@ -272,7 +272,7 @@
                 }
             } else if (this._otherstyledel) {
                 this._otherstyledel.unregisterAll();
-                delete this._otherstyledel;
+                this._otherstyledel = null;
             }
             _setstyle(s);
             ]]>
@@ -381,13 +381,13 @@
             } 
             if (this._otherstyledel) {
                 this._otherstyledel.unregisterAll();
-                delete this._otherstyledel;
+                this._otherstyledel = null;
             }
             if (this._styledel) {
                 this._styledel.unregisterAll();
-                delete this._styledel;
+                this._styledel = null;
             }
-            super.destroy.apply(this, arguments);
+            super.destroy();
             ]]>
         </method>
 

Modified: openlaszlo/trunk/lps/components/base/basedatacombobox.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/basedatacombobox.lzx	2008-09-03 19:44:30 UTC (rev 10865)
+++ openlaszlo/trunk/lps/components/base/basedatacombobox.lzx	2008-09-03 22:03:01 UTC (rev 10866)
@@ -132,7 +132,7 @@
               an issue where selectfirst="true" wasn't working for remote
               data.
               @keywords private -->
-        <method name="_updateSelectionOnData" ><![CDATA[
+        <method name="_updateSelectionOnData" args="ignore=null" ><![CDATA[
             var dp = new lz.datapointer(this);
             
             var arr = dp.xpathQuery(this.itemdatapath);



More information about the Laszlo-checkins mailing list