[Laszlo-checkins] r11488 - openlaszlo/trunk/WEB-INF/lps/lfc/controllers

bargull@openlaszlo.org bargull at openlaszlo.org
Fri Oct 17 09:02:41 PDT 2008


Author: bargull
Date: 2008-10-17 09:02:39 -0700 (Fri, 17 Oct 2008)
New Revision: 11488

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
Log:
Change 20081017-bargull-Fh1 by bargull at dell--p4--2-53 on 2008-10-17 11:37:05
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: embedded animatorgroups repeat indefinite

New Features:

Bugs Fixed: LPP-7178

Technical Reviewer: pbr
QA Reviewer: hminsky
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
The fix is relative simple, just set the "crepeat" property in "prepareStart()" (as in LzAnimator).
This prevents indefinite repeats (the regression from my change) and makes "repeat" work for embedded animatorgroups.
    

Tests:
laszlo-explorer menu
both testcases from the bugreport



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs	2008-10-17 16:00:29 UTC (rev 11487)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/controllers/LzAnimatorGroup.lzs	2008-10-17 16:02:39 UTC (rev 11488)
@@ -351,9 +351,6 @@
 
         this.isactive = true;
 
-        // store a copy of repeat for decrementing after each iteration
-        this.crepeat = this.repeat;
-
         this.prepareStart();
         this.updateDel.register(lz.Idle , "onidle");
         return true;
@@ -363,6 +360,8 @@
       * @access private
       */
     function prepareStart () :void {
+        // store a copy of repeat for decrementing after each iteration
+        this.crepeat = this.repeat;
         for (var i:int = this.animators.length - 1; i >= 0; i--) {
             this.animators[ i ].notstarted = true;
             //this.animators[ i ].prepareStart();



More information about the Laszlo-checkins mailing list