[Laszlo-checkins] r11372 - openlaszlo/trunk/demos/lzpix/classes

jcrowley@openlaszlo.org jcrowley at openlaszlo.org
Tue Oct 7 10:57:16 PDT 2008


Author: jcrowley
Date: 2008-10-07 10:47:10 -0700 (Tue, 07 Oct 2008)
New Revision: 11372

Modified:
   openlaszlo/trunk/demos/lzpix/classes/photo.lzx
Log:
Change 20081006-laszlo-4 by laszlo at T43-L3XEXMW on 2008-10-06 17:02:43 EDT
    in /home/laszlo/src/svn/openlaszlo/trunk-bigboss
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: DHTML only now: LZPIX: Scrolling with grid set to 3 pictures causes the text to move onto the picture

New Features:

Bugs Fixed: LPP-5441 - DHTML only now: LZPIX:
    Scrolling with grid set to 3 pictures causes
    the text to move onto the picture

Technical Reviewer: promanik
QA Reviewer: henry
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Made the text y positioning for photos a
    constraint rather than something that was reset
    by a method every time there was any change made
    to the image at all.

Tests: Run LzPix in DHTML.  Drag the slider so that
    there are two rows of three images.  Click the
    right arrow once or twice to move ahead to more
    images.  Move back and forth a bit.  It should
    no longer reposition the text to the middle of
    the image.
    
    Compare to an unmodified version, in which after
    changing the grid to three images across and
    scrolling ahead once or twice, the text would
    reposition itself to the center of the image.
    
    This should still function as expected in SWF.



Modified: openlaszlo/trunk/demos/lzpix/classes/photo.lzx
===================================================================
--- openlaszlo/trunk/demos/lzpix/classes/photo.lzx	2008-10-07 17:42:19 UTC (rev 11371)
+++ openlaszlo/trunk/demos/lzpix/classes/photo.lzx	2008-10-07 17:47:10 UTC (rev 11372)
@@ -190,6 +190,7 @@
         
         <!-- title -->
         <text text="" width="100" fgcolor="0x1b1191" fontsize="10" 
+              y="${classroot.height + 3}"
               name="txt" visible="false"><!-- Setting this initially to false
               seems to fix a visual issue where these would cluster on the
               upper left of the page in DHTML. -->
@@ -204,7 +205,6 @@
                var tw = Math.min(this.getTextWidth(),width);
                var tx = (classroot.width - tw)/2;
                this.setAttribute('x', tx);
-               this.setAttribute('y', classroot.height + 3);
              </method>
              <method name="makeVisible">
                 



More information about the Laszlo-checkins mailing list