[Laszlo-checkins] r11320 - in openlaszlo/trunk: WEB-INF/lps/lfc/helpers lps/components/base lps/components/debugger lps/components/utils/diagnostic/inspector

[pbr@openlaszlo.org]

Author: pbr
Date: 2008-10-02 06:55:10 -0700 (Thu, 02 Oct 2008)
New Revision: 11320

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs
   openlaszlo/trunk/lps/components/base/basewindow.lzx
   openlaszlo/trunk/lps/components/debugger/debugger.lzx
   openlaszlo/trunk/lps/components/utils/diagnostic/inspector/inspector.lzx
Log:
Change 20081001-Philip-8 by Philip at Philip-DC on 2008-10-01 19:46:16 EDT
    in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Revert onapply event

New Features:

Bugs Fixed: LPP-6941, LPP-6951

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
To address LPP-6941, any deprecation warning related to LzState#onapply was removed. The doc for onapply is updated and is no longer marked private.

To address LPP-6951, the earlier transformation of onapply -> onapplied was reverted. Andre indicated that /lps/components/debugger/debugger.lzx needs to be changed, but I don't think this is the case.
    

Tests:
http://localhost:8080/trunk/examples/components/window_example.lzx in all platforms
http://localhost:8080/trunk/test/smoke/smokecheck.lzx in swf8. (There are errors in dhtml/swf9 but are unrelated)

Files:
M      WEB-INF/lps/lfc/helpers/LzState.lzs
M      lps/components/utils/diagnostic/inspector/inspector.lzx
M      lps/components/base/basewindow.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20081001-Philip-8.tar


Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs	2008-10-02 13:44:15 UTC (rev 11319)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzState.lzs	2008-10-02 13:55:10 UTC (rev 11320)
@@ -110,9 +110,8 @@
   static var attributes = new LzInheritedHash(LzNode.attributes);
 
   /**
-   * Backward compatible version of `onapplied`
-   * @deprecated in 4.2
-   * @access private
+   * Sent before a state is applied. The event argument is the state
+   * that is being applied.
    * @lzxtype event
    */
   var onapply:LzDeclaredEventClass = LzDeclaredEvent;
@@ -184,10 +183,8 @@
 
   /** @access private */
   static var props = { apply : true }; // unused?
-  /**
-   * Remove onapply after 4.2
-   * @access private
-   */
+
+  /** @access private */
   static var events = { onremove : true , onapply : true, onapplied : true };
   prototype.$isstate = true; // Defined in LzNode
   /** @access private */
@@ -336,7 +333,6 @@
 
     parent.__LZdelegates = od;
 
-    // Remove onapply after 4.2
     if (this.onapply.ready) this.onapply.sendEvent( this );
     if (this.onapplied.ready) this.onapplied.sendEvent( true );
   }

Modified: openlaszlo/trunk/lps/components/base/basewindow.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/basewindow.lzx	2008-10-02 13:44:15 UTC (rev 11319)
+++ openlaszlo/trunk/lps/components/base/basewindow.lzx	2008-10-02 13:55:10 UTC (rev 11320)
@@ -68,7 +68,7 @@
         </method> 
 
         <!-- resizestatemin uses minwidth and minheight attribute-->
-        <resizestatemin name="_windowResize" resize_min_width="${this.minwidth}" resize_min_height="${this.minheight}" onapplied="parent.setAttribute('haswindowfocus', true)"/>
+        <resizestatemin name="_windowResize" resize_min_width="${this.minwidth}" resize_min_height="${this.minheight}" onapply="parent.setAttribute('haswindowfocus', true)"/>
 
         <!--- @keywords private -->
         <method name="construct" args="parent,args">

Modified: openlaszlo/trunk/lps/components/debugger/debugger.lzx
===================================================================
--- openlaszlo/trunk/lps/components/debugger/debugger.lzx	2008-10-02 13:44:15 UTC (rev 11319)
+++ openlaszlo/trunk/lps/components/debugger/debugger.lzx	2008-10-02 13:55:10 UTC (rev 11320)
@@ -532,8 +532,8 @@
     <dragstate name="drag"/>
     <resizestate name="resize"/>
 
-    <handler name="onapplied" reference="drag" method="saveDebuggerState"/>
-    <handler name="onapplied" reference="resize" method="saveDebuggerState"/>
+    <handler name="onremove" reference="drag" method="saveDebuggerState"/>
+    <handler name="onremove" reference="resize" method="saveDebuggerState"/>
             
 <method name="saveDebuggerState" args="d">
     if (this.persistedData) {

Modified: openlaszlo/trunk/lps/components/utils/diagnostic/inspector/inspector.lzx
===================================================================
--- openlaszlo/trunk/lps/components/utils/diagnostic/inspector/inspector.lzx	2008-10-02 13:44:15 UTC (rev 11319)
+++ openlaszlo/trunk/lps/components/utils/diagnostic/inspector/inspector.lzx	2008-10-02 13:55:10 UTC (rev 11320)
@@ -48,7 +48,7 @@
               text="${parent.text}"/>
 
         <state applied="${parent.editing}" pooling="true"
-               onapplied="parent.editbox.setAttribute('text', parent.text)"
+               onapply="parent.editbox.setAttribute('text', parent.text)"
                onremove="parent.setAttribute('text', parent.editbox.getText())">
             <edittext name="editbox" width="${parent.t.width + 10}">
                 <method name="init">