[Laszlo-checkins] r11934 - in openlaszlo/trunk/lps/components: base incubator incubator/rich-text incubator/test/opttree

[bargull@openlaszlo.org]

Author: bargull
Date: 2008-11-30 07:07:20 -0800 (Sun, 30 Nov 2008)
New Revision: 11934

Modified:
   openlaszlo/trunk/lps/components/base/baselist.lzx
   openlaszlo/trunk/lps/components/incubator/rich-text/linkdialog.lzx
   openlaszlo/trunk/lps/components/incubator/roundrectbutton.lzx
   openlaszlo/trunk/lps/components/incubator/stylishbutton.lzx
   openlaszlo/trunk/lps/components/incubator/test/opttree/treenode.lzx
Log:
Change 20081130-bargull-VjZ by bargull at dell--p4--2-53 on 2008-11-30 15:33:00
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix global color issues

New Features:

Bugs Fixed: LPP-7412

Technical Reviewer: (pending)
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
- use numeric constants instead of global values like "red" 
- changed "tint" and "fontcolor" type to "color" in stylishbutton.lzx
    

Tests:




Modified: openlaszlo/trunk/lps/components/base/baselist.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/baselist.lzx	2008-11-30 14:41:24 UTC (rev 11933)
+++ openlaszlo/trunk/lps/components/base/baselist.lzx	2008-11-30 15:07:20 UTC (rev 11934)
@@ -451,12 +451,8 @@
               </dataset>
             
               <class name="myitem" extends="baselistitem"
-                     bgcolor="${selected ? yellow : white}">
-                 <attribute name="text" type="text"/>
-                 <method name="applydata" args="d">
-                     setAttribute('text', d);
-                 </method>
-                 <text text="${parent.text}"/>
+                     bgcolor="${selected ? 0xffff00 : 0xffffff}">
+                 <text text="${parent.value}"/>
               </class>
             
               <baselist layout="axis:y; spacing:2">

Modified: openlaszlo/trunk/lps/components/incubator/rich-text/linkdialog.lzx
===================================================================
--- openlaszlo/trunk/lps/components/incubator/rich-text/linkdialog.lzx	2008-11-30 14:41:24 UTC (rev 11933)
+++ openlaszlo/trunk/lps/components/incubator/rich-text/linkdialog.lzx	2008-11-30 15:07:20 UTC (rev 11934)
@@ -69,7 +69,7 @@
             var url = urlfield.getText();
             var fmt = this.editor.getTextFormat(this.ssel, this.esel); 
             fmt.url = url;
-            fmt.color = blue; 
+            fmt.color = 0x0000FF; 
             fmt.target = "_new"; 
             fmt.underline = true; 
             this.editor.setTextFormat(fmt, this.ssel, this.esel);

Modified: openlaszlo/trunk/lps/components/incubator/roundrectbutton.lzx
===================================================================
--- openlaszlo/trunk/lps/components/incubator/roundrectbutton.lzx	2008-11-30 14:41:24 UTC (rev 11933)
+++ openlaszlo/trunk/lps/components/incubator/roundrectbutton.lzx	2008-11-30 15:07:20 UTC (rev 11934)
@@ -57,7 +57,7 @@
         this.setAttribute("downStartColor", s.basecolor)
         this.setAttribute("downStopColor", s.bgcolor)
 
-        this.setAttribute("overStartColor", white)
+        this.setAttribute("overStartColor", 0xFFFFFF)
         this.setAttribute("overStopColor", s.basecolor)
 
         this.setAttribute("upStartColor", s.hilitecolor)

Modified: openlaszlo/trunk/lps/components/incubator/stylishbutton.lzx
===================================================================
--- openlaszlo/trunk/lps/components/incubator/stylishbutton.lzx	2008-11-30 14:41:24 UTC (rev 11933)
+++ openlaszlo/trunk/lps/components/incubator/stylishbutton.lzx	2008-11-30 15:07:20 UTC (rev 11934)
@@ -34,10 +34,10 @@
     >
         <!--- Control the look of the button. These attributes can and should
               be controlled with css. --> 
-        <attribute name="tint" value="0xD9DCF5" />
+        <attribute name="tint" value="0xD9DCF5" type="color" />
         <attribute name="font" value="Verdana" />
         <attribute name="fontsize" value="11" /> 
-        <attribute name="fontcolor" value="0x373B56" />
+        <attribute name="fontcolor" value="0x373B56" type="color" />
 
         <!--- text to display in the button (can leave empty) -->
         <attribute name="text"      value=""  />
@@ -171,13 +171,13 @@
             middle.setAttribute('resource', middleresource);
                         
             if (showleftborder) {
-                new lz.view(this,    {name: "leftborder", bgcolor: white, 
+                new lz.view(this,    {name: "leftborder", bgcolor: 0xFFFFFF, 
                                      width: 1, y : 1, height: this.height-2, 
                                     pixellock: true});                 
             }
 
             if (showrightborder) {
-                new lz.view(this,    {name: "rightborder", bgcolor: black, 
+                new lz.view(this,    {name: "rightborder", bgcolor: 0x000000, 
                                     width: 1, y : 0, height: this.height-2,
                                     pixellock: true})
             }

Modified: openlaszlo/trunk/lps/components/incubator/test/opttree/treenode.lzx
===================================================================
--- openlaszlo/trunk/lps/components/incubator/test/opttree/treenode.lzx	2008-11-30 14:41:24 UTC (rev 11933)
+++ openlaszlo/trunk/lps/components/incubator/test/opttree/treenode.lzx	2008-11-30 15:07:20 UTC (rev 11934)
@@ -22,7 +22,7 @@
         </handler>
 
         <method name="setSelected" args="s">
-            label.setAttribute( "fgcolor", s ? red : black );
+            label.setAttribute( "fgcolor", s ? 0xFF0000 : 0x000000 );
         </method>
 
         <handler name="onclick">