[Laszlo-checkins] r11927 - openlaszlo/trunk/WEB-INF/lps/lfc/data

bargull@openlaszlo.org bargull at openlaszlo.org
Sat Nov 29 06:34:47 PST 2008


Author: bargull
Date: 2008-11-29 06:34:42 -0800 (Sat, 29 Nov 2008)
New Revision: 11927

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParsedPath.lzs
Log:
Change 20081129-bargull-nna by bargull at dell--p4--2-53 on 2008-11-29 12:02:55
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: add missing interface method

New Features:

Bugs Fixed: LPP-7409

Technical Reviewer: hminsky
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
The shared interface between LzDataset and LzDatapointer requires a "getContext()"- and a "getDataset()"-method, but AnonDatasetGenerator didn't implement the latter. So I've added that method and just let it return `null`, because we can't provide any further information. This is consistent with "LzDatapointer#getDataset()" which also may return `null`. 
    

Tests:
see bugreport



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParsedPath.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParsedPath.lzs	2008-11-29 11:49:41 UTC (rev 11926)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzParsedPath.lzs	2008-11-29 14:34:42 UTC (rev 11927)
@@ -358,7 +358,6 @@
       * @access private
       */
     var pp:LzParsedPath = null;
-    
 
     /**
       * @access private
@@ -386,34 +385,44 @@
       * @access private
       */
     var noncontext:Boolean = true;
-    
+
     /**
       * @access private
       */
     function AnonDatasetGenerator (pp:LzParsedPath) {
+        super();
         this.pp = pp;
     }
-    
+
     /** 
       * This is the shared interface with datapointer
       * @access private
       */
     function getContext () {
         //@devnote: this creates an anonymous dataset
-        var d = new LzDataset(null, {name: null});
-        
-        var ppsel = this.pp.selectors;
+        var d:LzDataset = new LzDataset(null, {name: null});
+
+        var ppsel:Array = this.pp.selectors;
         if (ppsel != null) {
-            var dp = d.getPointer();
-            for (var i = 0; i < ppsel.length; i++) {
+            var dp:LzDatapointer = d.getPointer();
+            for (var i:int = 0; i < ppsel.length; i++) {
                 if (ppsel[ i ] == "/") continue;
                 //TODO: test selector-type?
                 dp.addNode( ppsel[ i ] );
                 dp.selectChild();
             }
         }
-            
+
         return d;
     }
 
+    /** 
+      * This is the shared interface with datapointer
+      * @access private
+      */
+    function getDataset () {
+        // we only create one-way datasets, so we can't provide this information
+        return null;
+    }
+
 } // End of AnonDatasetGenerator



More information about the Laszlo-checkins mailing list