[Laszlo-checkins] r11703 - in openlaszlo/trunk: WEB-INF/lps/server/src/org/openlaszlo/compiler examples/components

[max@openlaszlo.org]

Author: max
Date: 2008-11-06 15:06:33 -0800 (Thu, 06 Nov 2008)
New Revision: 11703

Modified:
   openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
   openlaszlo/trunk/examples/components/list_example.lzx
Log:
Change 20081106-maxcarlson-K by maxcarlson at Bank on 2008-11-06 13:07:08 PST
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix list_example and colornaem conversion

Bugs Fixed: LPP-7305 - List example in Components is failing

Technical Reviewer: ptw
QA Reviewer: promanik

Details: NodeModel.java - Deal with TODO

list_example.lzx - Add type="color" to the app, remove ${} constraint.

Tests: list_example.lzx works across all runtimes



Modified: openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java	2008-11-06 21:32:02 UTC (rev 11702)
+++ openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java	2008-11-06 23:06:33 UTC (rev 11703)
@@ -1605,9 +1605,7 @@
                         value = "0x" +
                             Integer.toHexString(ViewSchema.parseColor(value));
                     } catch (ColorFormatException e) {
-                        // Or just set when to WHEN_ONCE and fall
-                        // through to TODO?
-                        throw new CompilationError(source, name, e);
+                        when = WHEN_ONCE;
                     }
                 }
                 value = "LzColorUtils.convertColor('" + value + "')";

Modified: openlaszlo/trunk/examples/components/list_example.lzx
===================================================================
--- openlaszlo/trunk/examples/components/list_example.lzx	2008-11-06 21:32:02 UTC (rev 11702)
+++ openlaszlo/trunk/examples/components/list_example.lzx	2008-11-06 23:06:33 UTC (rev 11703)
@@ -68,7 +68,7 @@
     </view>
 
     <class name="mylistitem" extends="listitem" height="20">
-        <attribute name="color" value="0x000000" when="once"/>
+        <attribute name="color" type="color" value="0x000000" when="once"/>
         <view x="4" y="5" width="10" height="10" bgcolor="${parent.color}"/>
         <text x="18" text="${parent.text}"/>
     </class>
@@ -99,7 +99,7 @@
         <view layout="axis:y;spacing:5">
             <text>custom colors, spacing=2</text>
             <list style="customlistcolors" spacing="2" shownitems="6"
-                bgcolor="${iceblue4}">
+                bgcolor="iceblue4">
                 <textlistitem>Peter</textlistitem>
                 <textlistitem>Bret</textlistitem>
                 <textlistitem>Sarah</textlistitem>