[Laszlo-checkins] r8447 - openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc

[dda@openlaszlo.org]

Author: dda
Date: 2008-03-27 12:17:19 -0700 (Thu, 27 Mar 2008)
New Revision: 8447

Modified:
   openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
Log:
Change 20080327-dda-Z by dda at lester.local on 2008-03-27 15:02:15 EDT
    in /Users/dda/laszlo/src/svn/openlaszlo/trunk-a/WEB-INF/lps/server/src/org/openlaszlo/sc
    for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc

Summary: SWF9: remove check to prevent classes beginning with '$'

New Features:

Bugs Fixed: LPP-5677 (partial)

Technical Reviewer: ptw (pending)
QA Reviewer: hminsky (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
    Removed a check for class names in SWF9 that is too stringent in the new world.
    Some classes are generated internally starting with '$', and all
    we really want to prevent are user classes named this way.
    This is to prevent collisions with our own namespace.  The
    proper place for this check would seem to be the tag compiler.

Tests:
    smokecheck swf8/dhtml
    henry's hello swf9
    henry's little class test that showed this error (gets further, anyway).



Modified: openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java	2008-03-27 19:16:16 UTC (rev 8446)
+++ openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java	2008-03-27 19:17:19 UTC (rev 8447)
@@ -159,8 +159,12 @@
    * @throw CompilerError if name has a potential conflict
    */
   public void checkClassName(String name) {
-    if (name.startsWith("$"))
-      throw new CompilerError(name + ": class or mixin name may conflict with internally generated names");
+    if (name.startsWith("$")) {
+      // TODO: [2008-3-27 dda] This test should be for names that
+      //      users pick.  We are using some names internally that
+      //      don't yet pass this test, so this check commented for now.
+      //      throw new CompilerError(name + ": class or mixin name may conflict with internally generated names");
+    }
   }
 
   // override superclass method.