[Laszlo-checkins] r8251 - openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc

[dda@openlaszlo.org]

Author: dda
Date: 2008-03-13 09:06:47 -0700 (Thu, 13 Mar 2008)
New Revision: 8251

Modified:
   openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
Log:
Change 20080313-dda-M by dda at lester.local on 2008-03-13 11:46:26 EDT
    in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
    for http://svn.openlaszlo.org/openlaszlo/branches/devildog

Summary: Fix interstitial constructor super calls for typed args

New Features:

Bugs Fixed: LPP-5561

Technical Reviewer: ptw (pending)
QA Reviewer: promanik (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
    The super() call within a manufactured constructor was wrong.
    It now leaves off any typing information as it is copying the
    arguments from the formal param list.

Tests:
    Fix: commented constructors in LzDataNodeMixin and LzDataElementMixin,
      it now compiles, eyeballed the generated code.
    Regression: SWF9 hello, {smokecheck,lzpix,weather} x {SWF8/DHTML}



Modified: openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
===================================================================
--- openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java	2008-03-13 15:56:39 UTC (rev 8250)
+++ openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java	2008-03-13 16:06:47 UTC (rev 8251)
@@ -471,12 +471,13 @@
       for (int i=0; i<origparams.length; i++) {
         if (origparams[i] instanceof ASTIdentifier) {
           ASTIdentifier id = (ASTIdentifier)origparams[i];
+
           if (id.getEllipsis()) {
             // Somewhat difficult to handle this case, and unknown
             // if it's worth the effort.
             throw new CompilerError(newname + ": cannot have variable args in constructor used as parent class of mixin");
           }
-          actuals.add(id);      // sharing the identifier
+          actuals.add(newIdentifier(id.getName()));
         }
       }
       SimpleNode[] actualsArray = (SimpleNode[])actuals.toArray(new SimpleNode[0]);