[Laszlo-checkins] r8239 - openlaszlo/trunk/lps/components/base

[max@openlaszlo.org]

Author: max
Date: 2008-03-12 17:18:34 -0700 (Wed, 12 Mar 2008)
New Revision: 8239

Modified:
   openlaszlo/trunk/lps/components/base/basedatacombobox.lzx
Log:
Change 20080312-maxcarlson-D by maxcarlson at Roboto.local on 2008-03-12 14:57:41 PDT
    in /Users/maxcarlson/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix bogus calls to basedatacombobox._updateSelectionByIndex()

New Features:

Bugs Fixed: LPP-5549 - basedatacombobox.onselect event fires even if selectfirst attribute is set to false

Technical Reviewer: promanik
QA Reviewer: enw at laszlosystems.com
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Make sure the index is valid in _updateSelectionByIndex();
    

Tests: See LPP-5549



Modified: openlaszlo/trunk/lps/components/base/basedatacombobox.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/basedatacombobox.lzx	2008-03-12 21:59:56 UTC (rev 8238)
+++ openlaszlo/trunk/lps/components/base/basedatacombobox.lzx	2008-03-13 00:18:34 UTC (rev 8239)
@@ -1,5 +1,5 @@
 <!-- * X_LZ_COPYRIGHT_BEGIN ***************************************************
-* Copyright 2005-2007 Laszlo Systems, Inc. All Rights Reserved.               *
+* Copyright 2005-2008 Laszlo Systems, Inc. All Rights Reserved.               *
 * Use is subject to license terms.                                            *
 * X_LZ_COPYRIGHT_END ****************************************************** -->
 <!-- @LZX_VERSION@                                                         -->
@@ -236,6 +236,7 @@
               @keywords private -->
         <method name="_updateSelectionByIndex" 
                 args="index,dontSetValue,isinitvalue"> <![CDATA[
+            if (index < 0) return;    
             var dp = new LzDatapointer(this);
 
             var nodes = dp.xpathQuery(this.itemdatapath);