[Laszlo-checkins] r8198 - openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc

[dda@openlaszlo.org]

Author: dda
Date: 2008-03-06 12:47:03 -0800 (Thu, 06 Mar 2008)
New Revision: 8198

Modified:
   openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
Log:
Change 20080306-dda-y by dda at lester.local on 2008-03-06 15:43:23 EST
    in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildogm
    for http://svn.openlaszlo.org/openlaszlo/branches/devildog

Summary: SWF9: remove warning about non-null optional arguments.

New Features:

Bugs Fixed: LPP-5273

Technical Reviewer: ptw (pending)
QA Reviewer: hminsky (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
   We expected there to be a limitation on optional arguments, requiring them
   to be null.  There are no limitations on any platforms, so the warning message
   for this case is removed.

Tests:
   smokecheck (swf8/dhtml) + henry's hello.



Modified: openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
===================================================================
--- openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java	2008-03-06 20:46:50 UTC (rev 8197)
+++ openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java	2008-03-06 20:47:03 UTC (rev 8198)
@@ -663,13 +663,9 @@
       if (param instanceof ASTIdentifier) {
         paramCount++;
       }
-      else if (!(param instanceof ASTFormalInitializer) ||
-               param.size() != 1 ||
-               !((child = param.getChildren()[0]) instanceof ASTLiteral) ||
-               ((ASTLiteral)child).getValue() != null) {
-        System.err.println("Warning: parameter initializer must be null" +
-                           " in " + param.filename + 
-                           " (" + param.beginLine + ")");
+      else if (!(param instanceof ASTFormalInitializer) || param.size() != 1) {
+        System.err.println("Warning: unknown formal parameter in " +
+                           param.filename + " (" + param.beginLine + ")");
       }
     }