[Laszlo-checkins] r10010 - openlaszlo/trunk/WEB-INF/lps/lfc/data

[bargull@openlaszlo.org]

Author: bargull
Date: 2008-06-26 01:31:07 -0700 (Thu, 26 Jun 2008)
New Revision: 10010

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
Log:
Change 20080625-bargull-5lt by bargull at dell--p4--2-53 on 2008-06-25 22:36:40
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: don't be too smart with array-bounds

New Features:

Bugs Fixed: LPP-6515

Technical Reviewer: hminsky
QA Reviewer: promanik
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
I've tried to be smart and define the array-size, but I've failed.
(the other change should make constrained datapath work in swf9)
    

Tests:
see bugreport



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs	2008-06-26 08:27:42 UTC (rev 10009)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs	2008-06-26 08:31:07 UTC (rev 10010)
@@ -272,7 +272,7 @@
 
     LzInstantiator.enableDataReplicationQueuing( );
     var oldclones:Array = this.clones;
-    this.clones = new Array(newlength);
+    this.clones = [];
 
     for ( var i:int = 0; i < newlength; i++ ){
         //before the new beginning

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs	2008-06-26 08:27:42 UTC (rev 10009)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs	2008-06-26 08:31:07 UTC (rev 10010)
@@ -314,7 +314,9 @@
         // a constraint on the clone via the normal mechanism?
         // but, we want the constraint to apply to this object instead
         if ($swf9) {
-            //FIXME: cannot copy a method in swf9, because 'this' is bound!
+            //FIXME: cannot copy a method in swf9, because 'this' is bound (LPP-6066)
+            // if a datapath-attribute was compiled as a datapath-node, this wouldn't 
+            // be a problem anymore (LPP-4386, LPP-6171)
             this.__LZxpathconstr = function (ignore) {};
             this.__LZxpathdepend = function () {return [];};
         } else {
@@ -340,14 +342,10 @@
         // like "xpath='${this.immediateparent.parent.anyproperty}'" 
         // work for a replication-manager 
         var refObj:LzRefNode = new LzRefNode(this);
-        if ($swf9) {
-            //FIXME: cannot copy a method in swf9, because 'this' is bound!
-            refObj.__LZxpathconstr = function (ignore) {};
-            refObj.__LZxpathdepend = function () {return [];};
-        } else {
-            refObj.__LZxpathconstr = odp[oa.xpath.methodName];
-            refObj.__LZxpathdepend = odp[oa.xpath.dependenciesName];
-        }
+        // the constraint-method isn't actually a method for LzDatapath, 
+        // but a function, which is available through the odp's _instanceAttrs
+        refObj.__LZxpathconstr = oa[oa.xpath.methodName];
+        refObj.__LZxpathdepend = oa[oa.xpath.dependenciesName];
         // NOTE: [2008-02-07 ptw] The method had better be available
         // on the clone (which means the compiler really has to move
         // it from the datapath subnode to the clone class).