[Laszlo-checkins] r9629 - openlaszlo/trunk/WEB-INF/lps/lfc/data

[bargull@openlaszlo.org]

Author: bargull
Date: 2008-06-13 05:14:18 -0700 (Fri, 13 Jun 2008)
New Revision: 9629

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzResizeReplicationManager.lzs
Log:
Change 20080612-bargull-737 by bargull at dell--p4--2-53 on 2008-06-12 01:07:26
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Pooling for replication-managers

New Features:

Bugs Fixed: LPP-5997

Technical Reviewer: hminsky
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
The previous changeset was erroneous, I was wrong about in which order constructor and construct-method are called. 
    

Tests:



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs	2008-06-13 12:03:17 UTC (rev 9628)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDatapath.lzs	2008-06-13 12:14:18 UTC (rev 9629)
@@ -245,7 +245,7 @@
     if ( this.__LZtakeDPSlot ){
         if ($debug) {
             if (this.immediateparent.datapath != null) {
-                Debug.warn("overring datapath %w with %w", this.immediateparent.datapath, this);
+                Debug.warn("overriding datapath %w with %w", this.immediateparent.datapath, this);
             }
         }
         this.immediateparent.datapath = this;

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs	2008-06-13 12:03:17 UTC (rev 9628)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs	2008-06-13 12:14:18 UTC (rev 9629)
@@ -84,8 +84,12 @@
   */
 function LzLazyReplicationManager ( odp , args, children:* = null, instcall:* = null ){
     super(odp, args, children, instcall);
+}
+
+/** @access private */
+override protected function getDefaultPooling () :Boolean {
     //replication argument needs to control pooling
-    this.pooling = true; // Defined in LzDatapath
+    return true;
 }
 
 /** @access private */

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs	2008-06-13 12:03:17 UTC (rev 9628)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs	2008-06-13 12:14:18 UTC (rev 9629)
@@ -167,14 +167,19 @@
   * @access private
   */
 function LzReplicationManager ( odp , args, children:* = null, instcall:* = null ){
+    this.pooling = this.getDefaultPooling(); // Defined in LzDatapath
+    this.__LZtakeDPSlot = false; // Defined in LzDatapath
+    this.datacontrolsvisibility = false; // Defined in LzDatapath
     //the real parent for this is datapaths view's (immediateparent) parent
     super(odp, args, children, instcall);
-    this.pooling = false; // Defined in LzDatapath
-    this.__LZtakeDPSlot = false; // Defined in LzDatapath
-    this.datacontrolsvisibility = false; // Defined in LzDatapath
 }
 
 /** @access private */
+protected function getDefaultPooling () :Boolean {
+    return false;
+}
+
+/** @access private */
 override function construct ( odp , args ){
     //odp: original datapath
     var view:LzNode = odp.immediateparent;

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzResizeReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzResizeReplicationManager.lzs	2008-06-13 12:03:17 UTC (rev 9628)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzResizeReplicationManager.lzs	2008-06-13 12:14:18 UTC (rev 9629)
@@ -93,9 +93,13 @@
   */
 function LzResizeReplicationManager ( odp , args, children:* = null, instcall:* = null ){
     super(odp, args, children, instcall);
+}
+
+/** @access private */
+override protected function getDefaultPooling () :Boolean {
     //need to destroy the original clone for resize in order to insert the
     //appropriate onwidth-/onheight-delegate
-    this.pooling = false; // Defined in LzDatapath
+    return false;
 }
 
 /** @access private */