[Laszlo-checkins] r9502 - openlaszlo/trunk/demos/calendar

pbr@openlaszlo.org pbr at openlaszlo.org
Fri Jun 6 14:25:45 PDT 2008


Author: pbr
Date: 2008-06-06 14:25:40 -0700 (Fri, 06 Jun 2008)
New Revision: 9502

Modified:
   openlaszlo/trunk/demos/calendar/cal-button.lzx
   openlaszlo/trunk/demos/calendar/calendar.lzx
   openlaszlo/trunk/demos/calendar/day.lzx
   openlaszlo/trunk/demos/calendar/event.lzx
   openlaszlo/trunk/demos/calendar/eventselector.lzx
   openlaszlo/trunk/demos/calendar/gridsliderlayout.lzx
   openlaszlo/trunk/demos/calendar/infopanel.lzx
   openlaszlo/trunk/demos/calendar/selected-daylook.lzx
Log:
Change 20080605-Philip-8 by Philip at Philip-DC on 2008-06-05 11:05:53 EDT
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk_clean
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fix warnings in calendar demo

New Features:

Bugs Fixed: LPP-6060 (partial)

Technical Reviewer: josh
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
I ran the migration tool (WEB-INF/lps/server/bin/convert_laszlo.pl)
on the calendar files. I also added an argument to delegate methods to silence the warnings.


Tests:
Calendar runs without any warnings

Files:
M      demos/calendar/cal-button.lzx
M      demos/calendar/calendar.lzx
M      demos/calendar/infopanel.lzx
M      demos/calendar/day.lzx
M      demos/calendar/event.lzx
M      demos/calendar/eventselector.lzx
M      demos/calendar/gridsliderlayout.lzx
M      demos/calendar/selected-daylook.lzx

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20080605-Philip-8.tar



Modified: openlaszlo/trunk/demos/calendar/cal-button.lzx
===================================================================
--- openlaszlo/trunk/demos/calendar/cal-button.lzx	2008-06-06 19:52:23 UTC (rev 9501)
+++ openlaszlo/trunk/demos/calendar/cal-button.lzx	2008-06-06 21:25:40 UTC (rev 9502)
@@ -214,7 +214,7 @@
    </handler>
 
     <!-- OTHER METHODS -->
-    <method name="safeclick" >
+    <method name="safeclick" args="v" >
         this.ocd.unregisterAll()
         if (this.onsafeclick) {
             this.onsafeclick.sendEvent();

Modified: openlaszlo/trunk/demos/calendar/calendar.lzx
===================================================================
--- openlaszlo/trunk/demos/calendar/calendar.lzx	2008-06-06 19:52:23 UTC (rev 9501)
+++ openlaszlo/trunk/demos/calendar/calendar.lzx	2008-06-06 21:25:40 UTC (rev 9502)
@@ -58,12 +58,12 @@
                 <!-- shows the day titles if necessary when the grid stops
                      updating -->
                 <handler name="onupdatestop" method="showalldaytitles" reference="calgrid.gridlayout" />
-                <method name="showalldaytitles">
+                <method name="showalldaytitles" args="v">
                   <![CDATA[
                     if ( calgrid.gridlayout.displaymode != 'cell' ){
                         var svs = this.subviews;
                         for (var i = 0; i < 7; i++) {
-                            svs[i].setVisible(true);
+                            svs[i].setAttribute('visible', true);
                         }
                     } ]]>
                 </method>
@@ -233,7 +233,7 @@
 
           <!-- METHODS -->
           <method name="finishStartSequence">
-              cal_interior.setVisible( true );
+              cal_interior.setAttribute('visible',  true );
               var now = new Date();
               this.setMonthAndYear(now.getMonth(), now.getFullYear());
               cal_interior.fadeUp.doStart();
@@ -331,9 +331,9 @@
               var svs = toppanel.weekbkgnd.daynames.subviews;
               for (var i = 0; i < 7; i++){
                   if (i == dayindex)
-                      svs[i].setVisible(true);
+                      svs[i].setAttribute('visible', true);
                   else
-                      svs[i].setVisible(false);
+                      svs[i].setAttribute('visible', false);
               }
           ]]> </method>
 

Modified: openlaszlo/trunk/demos/calendar/day.lzx
===================================================================
--- openlaszlo/trunk/demos/calendar/day.lzx	2008-06-06 19:52:23 UTC (rev 9501)
+++ openlaszlo/trunk/demos/calendar/day.lzx	2008-06-06 21:25:40 UTC (rev 9502)
@@ -18,10 +18,10 @@
                    
         <method name="animateTo" args="tox,toy,towidth,toheight">
             // Debug.write("animateTo",tox,toy,towidth,toheight, this);
-            slideranim.xanim.setTo(tox);
-            slideranim.yanim.setTo(toy);
-            slideranim.widthanim.setTo(towidth);
-            slideranim.heightanim.setTo(toheight);
+            slideranim.xanim.setAttribute("to", tox);
+            slideranim.yanim.setAttribute("to", toy);
+            slideranim.widthanim.setAttribute("to", towidth);
+            slideranim.heightanim.setAttribute("to", toheight);
             slideranim.doStart();
         </method>
                 

Modified: openlaszlo/trunk/demos/calendar/event.lzx
===================================================================
--- openlaszlo/trunk/demos/calendar/event.lzx	2008-06-06 19:52:23 UTC (rev 9501)
+++ openlaszlo/trunk/demos/calendar/event.lzx	2008-06-06 21:25:40 UTC (rev 9502)
@@ -102,11 +102,11 @@
 
         <method name="openToggle" args="o">
             if ( o ){
-                this.timeArea.setVisible( false );
+                this.timeArea.setAttribute('visible',  false );
                 this.smalltitletext.setX( 10 );
                 this.timekgnd.setBGColor(this.bkgndColor);
             } else {
-                this.timeArea.setVisible( true );
+                this.timeArea.setAttribute('visible',  true );
                 this.smalltitletext.setX( 25 );
                 this.setX( 0 );
                 this.setHeight(22);

Modified: openlaszlo/trunk/demos/calendar/eventselector.lzx
===================================================================
--- openlaszlo/trunk/demos/calendar/eventselector.lzx	2008-06-06 19:52:23 UTC (rev 9501)
+++ openlaszlo/trunk/demos/calendar/eventselector.lzx	2008-06-06 21:25:40 UTC (rev 9502)
@@ -102,7 +102,7 @@
         </handler>
 
         <method name="hide">
-            bar.setVisible(false);
+            bar.setAttribute('visible', false);
             bar.followstate.remove();
             this.followview = null;
             this.clipdel.unregisterAll();
@@ -142,7 +142,7 @@
 
 
             // update eventselector view
-            bar.setVisible( true );
+            bar.setAttribute('visible',  true );
             this.bringToFront();
 
 
@@ -219,13 +219,13 @@
             }]]>
         </handler>
 
-        <method name="checkClip"><![CDATA[
+        <method name="checkClip" args="v"><![CDATA[
             if ( followview.classroot.opened && this.freedragging ){
                 this.setAttribute( "freedragging" , false );
             }]]>
         </method>
 
-        <method name="checkHide"><![CDATA[
+        <method name="checkHide" args="v"><![CDATA[
             if ( !followview.classroot.visible ){
                 this.hide();
             }]]>
@@ -238,7 +238,7 @@
         </handler>
 
         <handler name="onmousedown" method="domousedown"/>
-        <method name="domousedown"><![CDATA[
+        <method name="domousedown" args="v"><![CDATA[
             //wait 150ms before starting drag; prevents moving the 
             //event selector on a click -- 150ms is empirical
             this.origx = bar.x;
@@ -250,7 +250,7 @@
             ]]>
         </method>
 
-        <method name="startDrag">   <![CDATA[
+        <method name="startDrag" args="v">   <![CDATA[
             this.mdel.register( LzIdle, "onidle" );
             bar.followstate.remove();
             this.setAttribute('freedragging', !followview.classroot.opened );
@@ -259,7 +259,7 @@
         </method>
 
         <handler name="onmouseup" method="domouseup"/>
-        <method name="domouseup"><![CDATA[
+        <method name="domouseup" args="v"><![CDATA[
             if ( this.dragging ){
                 this.mdel.unregisterAll( );
                 this.setAttribute('dragging',false);
@@ -298,7 +298,7 @@
 
         <attribute name="snapEdge" value="30"/>
 
-        <method name="trackmouse"><![CDATA[
+        <method name="trackmouse" args="v"><![CDATA[
             //may not be free dragging anymore
             var needset = true;
 

Modified: openlaszlo/trunk/demos/calendar/gridsliderlayout.lzx
===================================================================
--- openlaszlo/trunk/demos/calendar/gridsliderlayout.lzx	2008-06-06 19:52:23 UTC (rev 9501)
+++ openlaszlo/trunk/demos/calendar/gridsliderlayout.lzx	2008-06-06 21:25:40 UTC (rev 9502)
@@ -228,7 +228,7 @@
 
     <event name="onupdatestart" />
     <!-- METHOD: update -->
-    <method name="update" >
+    <method name="update" args="v">
         <![CDATA[
         if ( this['locked'] ) { return }
         if (this.onupdatestart) {
@@ -327,7 +327,7 @@
                         if (s.y != y)       s.setY(y);
                         if (s.width != w)   s.setWidth(w);
                         if (s.height != h)  s.setHeight(h);
-                        if (!s.visible) s.setVisible(true);
+                        if (!s.visible) s.setAttribute('visible', true);
                     }
                 } else {
                    if (rowi ==0) {
@@ -341,7 +341,7 @@
                             if (s.width != w)   s.setWidth(w);
                         }
                     }
-                    if (s.visible) s.setVisible(false);
+                    if (s.visible) s.setAttribute('visible', false);
                     s.update_vis_later = false;
                 }
 
@@ -358,7 +358,7 @@
          // Check to see if we need the last row, and if not hide these days
          if (nrows == 5) { // hide last row
             for (var c = 35; c < 42; c++) {
-                this.subviews[c].setVisible(false);
+                this.subviews[c].setAttribute('visible', false);
                 this.subviews[c].update_vis_later = false;
              }
          }
@@ -381,15 +381,15 @@
     </method>
 
     <event name="onupdatestop" />
-    <method name="resetVisibility" ><![CDATA[
+    <method name="resetVisibility" args="v"><![CDATA[
         // Debug.write("resetting visibility");
         // Now show the views that were hidden
         var s;
         for (var i =0; i < this.subviews.length; i++) {
             s = this.subviews[i];
             if (s['update_vis_later']){
-                if (!s.opened && s.details.bgrect.dataview) s.details.bgrect.dataview.setY(0);            
-                s.setVisible(true);
+                if (!s.opened && s.details.bgrect.container.dataview) s.details.bgrect.container.dataview.setY(0);            
+                s.setAttribute('visible', true);
             }
 
         }
@@ -423,7 +423,7 @@
         }
     </method>
 
-    <method name="checkMousePosition" ><![CDATA[
+    <method name="checkMousePosition" args="v"><![CDATA[
         //this runs every frame while dragging -- it's private to the layout
         var x = immediateparent.getMouse( 'x' );
         var y = immediateparent.getMouse( 'y' );

Modified: openlaszlo/trunk/demos/calendar/infopanel.lzx
===================================================================
--- openlaszlo/trunk/demos/calendar/infopanel.lzx	2008-06-06 19:52:23 UTC (rev 9501)
+++ openlaszlo/trunk/demos/calendar/infopanel.lzx	2008-06-06 21:25:40 UTC (rev 9502)
@@ -44,7 +44,7 @@
         <!-- METHODS -->
         <handler name="onopenstart" >
             // tab is about to open
-            this.interior.setVisible(true);
+            this.interior.setAttribute('visible', true);
             this.top.setBGColor(0xE2E4DF);
             this.top.tline.setBGColor(0xB8B9B5)
             this.top.bline.setBGColor(0xFDFFFF)
@@ -59,7 +59,7 @@
 
         <handler name="onclosestop" >
             //tab is closed
-            this.interior.setVisible(false);
+            this.interior.setAttribute('visible', false);
         </handler>
 
         <method name="toggle">
@@ -315,7 +315,7 @@
 
             calgrid.contract();
 
-            this.setVisible(true);
+            this.setAttribute('visible', true);
             this.setOpacity(1);
             this.slideopen1.doStart();
             this.slideopen2.doStart();
@@ -334,7 +334,7 @@
         <method name="close_done" >
             //Debug.write("close_done");
             calgrid.expand();
-            this.setVisible(false);
+            this.setAttribute('visible', false);
         </method>
 
         <method name="unselectEvent" >

Modified: openlaszlo/trunk/demos/calendar/selected-daylook.lzx
===================================================================
--- openlaszlo/trunk/demos/calendar/selected-daylook.lzx	2008-06-06 19:52:23 UTC (rev 9501)
+++ openlaszlo/trunk/demos/calendar/selected-daylook.lzx	2008-06-06 21:25:40 UTC (rev 9502)
@@ -60,7 +60,7 @@
         <!-- METHODS -->
 
         <method name="hide"> <![CDATA[
-            setVisible(false);
+            setAttribute('visible', false);
         ]]></method>
 
         <method name="setOpened" args="o">
@@ -87,7 +87,7 @@
                 this.followstate.apply();
             }
 
-            setVisible(true); ]]>
+            setAttribute('visible', true); ]]>
         </method>
 
         <state name="followstate" applied="false">



More information about the Laszlo-checkins mailing list