[Laszlo-checkins] r9448 - in openlaszlo/trunk: lps/components/base test/components/lz

[jcrowley@openlaszlo.org]

Author: jcrowley
Date: 2008-06-03 16:10:17 -0700 (Tue, 03 Jun 2008)
New Revision: 9448

Modified:
   openlaszlo/trunk/lps/components/base/basecomponent.lzx
   openlaszlo/trunk/test/components/lz/test-basetabs.lzx
Log:
Change 20080603-laszlo-2 by laszlo at T43-L3XEXMW on 2008-06-03 05:48:36 EDT
    in /home/laszlo/src/svn/openlaszlo/trunk-3
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: test-basetabs.lzx reference to undefined variable goldstyle

New Features:

Bugs Fixed: LPP-3998 - test-basetabs.lzx reference to undefined variable goldstyle

Technical Reviewer: max at openlaszlo.org
QA Reviewer: a.bargull at intensis.de
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: Fixed the warning and the error that were showing up in
    the Debugger when running the test file.  (One was a needless
    reference to a style class; the other was a reference to an
    attribute without first checking whether the attribute was
    defined.

Tests: Run /test/components/lz/test-basetabs.lzx.  It should behave
    as expected, but without warning messages.



Modified: openlaszlo/trunk/lps/components/base/basecomponent.lzx
===================================================================
--- openlaszlo/trunk/lps/components/base/basecomponent.lzx	2008-06-03 22:38:12 UTC (rev 9447)
+++ openlaszlo/trunk/lps/components/base/basecomponent.lzx	2008-06-03 23:10:17 UTC (rev 9448)
@@ -351,7 +351,8 @@
 
         <!--- @access private -->
         <method name="destroy">
-            if ( this.isdefault) {
+            <![CDATA[
+            if (this['isdefault'] && this.isdefault) {
                 lz._componentmanager.service.unmakeDefault( this );
             } 
             if (this._otherstyledel) {
@@ -363,6 +364,7 @@
                 delete this._styledel;
             }
             super.destroy.apply(this, arguments);
+            ]]>
         </method>
 
         <!--- @access private -->

Modified: openlaszlo/trunk/test/components/lz/test-basetabs.lzx
===================================================================
--- openlaszlo/trunk/test/components/lz/test-basetabs.lzx	2008-06-03 22:38:12 UTC (rev 9447)
+++ openlaszlo/trunk/test/components/lz/test-basetabs.lzx	2008-06-03 23:10:17 UTC (rev 9448)
@@ -1,8 +1,6 @@
 <canvas width="1000" height="1000" debug="true">
 
     <debug x="280" y="10" height="300" />
-    <goldstyle name="goldcolors"/>
-    <attribute name="defaultstyle" value="${goldstyle}"/>
 
     <method name="newWorktab"><![CDATA[ 
         var tab_id = "newtab";
@@ -343,6 +341,6 @@
     </view>
 </canvas>
 <!-- * X_LZ_COPYRIGHT_BEGIN ***************************************************
-* Copyright 2001-2007 Laszlo Systems, Inc.  All Rights Reserved.              *
+* Copyright 2001-2008 Laszlo Systems, Inc.  All Rights Reserved.              *
 * Use is subject to license terms.                                            *
 * X_LZ_COPYRIGHT_END ****************************************************** -->