[Laszlo-checkins] r10482 - openlaszlo/trunk/WEB-INF/lps/lfc/core

[bargull@openlaszlo.org]

Author: bargull
Date: 2008-07-25 11:40:50 -0700 (Fri, 25 Jul 2008)
New Revision: 10482

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
Log:
Change 20080725-bargull-hH2 by bargull at dell--p4--2-53 on 2008-07-25 15:36:48
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: remove (now) unnecessary attrs-copy

New Features:

Bugs Fixed: LPP-6553

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
I guess it's just now longer necessary.
    

Tests:



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs	2008-07-25 18:15:50 UTC (rev 10481)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs	2008-07-25 18:40:50 UTC (rev 10482)
@@ -270,10 +270,6 @@
       LzNode.mergeAttributes(attrs, iargs);
     }
 
-    // TODO: [2006-05-22 ptw] What is the purpose of this copy?
-    // construct or constructWithArgs destructively modify args?
-    var maskedargs = new LzInheritedHash(iargs);
-
     //Flag if this was newed by the instantiator
     this.__LZisnew = !instcall;
 
@@ -283,11 +279,11 @@
     }
 
     // If a 'datapath' init arg was passed, we must override any existing $datapath
-    if (maskedargs['datapath'] != null) {
-      delete maskedargs["$datapath"];
+    if (iargs['datapath'] != null) {
+      delete iargs["$datapath"];
     }
 
-    this.construct(  parent , maskedargs );
+    this.construct(  parent , iargs );
 
     // Construct may, through many tangled webs of replication and
     // placement, actually end up deleting us!  Bail out.
@@ -295,7 +291,7 @@
 
     //        this.setClassEvents( this.constructor );
 
-    this.__LZapplyArgs( maskedargs , true );
+    this.__LZapplyArgs( iargs , true );
 
     // If a replicator was made, we're deleted, if pooling is off.
     if (this.__LZdeleted) { return; }
@@ -304,7 +300,7 @@
      * @todo 2006-05-24 ptw Adam says this is a hack that we should get
      * rid of.
      */
-    this.constructWithArgs( maskedargs );
+    this.constructWithArgs( iargs );
 
     this.__LZdeferDelegates = null;
     if (qpos != LzDelegate.__LZdelegatesQueue.length) {