[Laszlo-checkins] r10380 - in openlaszlo/trunk/WEB-INF/lps/lfc: data views

Wed Jul 16 05:16:42 PDT 2008

Author: hqm
Date: 2008-07-16 05:16:38 -0700 (Wed, 16 Jul 2008)
New Revision: 10380

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
   openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloCanvas.lzs
Log:
Change 20080715-hqm-9 by hqm at badtzmaru.home on 2008-07-15 23:20:47 EDT
    in /Users/hqm/openlaszlo/trunk4/WEB-INF/lps/lfc
    for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc

Summary: fix for canvas.datasets bug

New Features:

Bugs Fixed: LPP-6668

Technical Reviewer: ptw
QA Reviewer: pbr
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

+ dataset names are not being set properly into canvas.datasets, because
a check for initializing it in LzDataset.set_name is incorrect
    
fix is to make LzCanvas initialize canvas.datasets to {}, and to 
remove the null check in LzDataset.$lzc$set_name


Tests:

test/lfc/data/alldata.lzx

smokecheck

swf9 alldata tests get farther



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
===================================================================

--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs	2008-07-16 08:30:07 UTC (rev 10379)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs	2008-07-16 12:16:38 UTC (rev 10380)
@@ -348,10 +348,6 @@
         //for compatibility with dataNode API
         this.nodeName = name;
         
-        if (!('datasets' in canvas) || null == canvas.datasets ) {
-            canvas.datasets = {};
-        }
-        
         if ( this.oncanvas ){
             canvas[ name ] = this;
         } else {
@@ -462,7 +458,7 @@
                 
     this.data = data;
 
-    if ('responseheaders' in this && this.responseheaders != null) {
+    if (this.responseheaders != null) {
         this.responseheaders.destroy();
     }
     this.responseheaders = headers;

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs	2008-07-16 08:30:07 UTC (rev 10379)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs	2008-07-16 12:16:38 UTC (rev 10380)
@@ -304,7 +304,7 @@
             // For proxied requests, we get back an XML wrapper
             // <resulset><body>DATA</body><headers>HEADERS</headers></resultset>
             // extract the headers and body below:
-            var hos = ('childNodes' in data.childNodes[1]) ? data.childNodes[1].childNodes : null;
+            var hos = (data.childNodes[1].childNodes) ? data.childNodes[1].childNodes : null;
             // get proxy metadata (header, etc) info if any
             if (hos != null) {
                 for ( var i = 0; i < hos.length; i++ ){

Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloCanvas.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloCanvas.lzs	2008-07-16 08:30:07 UTC (rev 10379)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloCanvas.lzs	2008-07-16 12:16:38 UTC (rev 10380)
@@ -162,6 +162,7 @@
       */
     function LzCanvas ( parent = null, args = null, children = null, async = null) {
       super(parent, args, children, async);
+      this.datasets = {};
     }
 
     /**
@@ -457,9 +458,8 @@
 /** Dictionary of all named datasets.
   * @type Object
   */
-var datasets;
+var datasets = null;
 
-
 /**
   * Compares two version strings.
   * @access private

