[Laszlo-checkins] r7892 - openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc

[dda@openlaszlo.org]

Author: dda
Date: 2008-01-25 12:55:10 -0800 (Fri, 25 Jan 2008)
New Revision: 7892

Modified:
   openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
Log:
Change 20080125-dda-o by dda at lester.local on 2008-01-25 14:06:29 EST
    in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
    for http://svn.openlaszlo.org/openlaszlo/branches/devildog

Summary: SWF9: fix unparser problem in inserting spaces

New Features:

Bugs Fixed: LPP-5234

Technical Reviewer: ptw (pending)
QA Reviewer: promanik (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

Errors reported by Phil with LzCanvas not defined.
We believe this is an unparsing bug.  The new unparser adds annotations to the
text (with line number, class info) that is eventually removed.  So any code
that examines unparsed strings must 'unannotate' to see the clear text string.

The weather demo that Phil noticed this error in for DHTML works fine for me
(in DHTML and SWF8) before and after the fix, so I'm not 100% this will completely
fix the error he is seeing, but it seems likely given the description.

Tests:
  demo/weather
     SWF8+DHTML
  smokecheck
     SWF8+DHTML   (1 failure for SWF8, which was there previously)
  swf9/hello



Modified: openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
===================================================================
--- openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java	2008-01-25 20:03:57 UTC (rev 7891)
+++ openlaszlo/branches/devildog/WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java	2008-01-25 20:55:10 UTC (rev 7892)
@@ -678,7 +678,7 @@
       sb.append(space);
       sb.append(op);
       // Disambiguate `a + ++b`, `a++ + b` etc.
-      sb.append(delimit(child, required || opChar == child.charAt(0)));
+      sb.append(delimit(child, required || opChar == unannotate(child).charAt(0)));
     }
     return(sb.toString());
   }