[Laszlo-checkins] r8085 - openlaszlo/trunk/WEB-INF/lps/lfc/data

[hqm@openlaszlo.org]

Author: hqm
Date: 2008-02-20 21:19:17 -0800 (Wed, 20 Feb 2008)
New Revision: 8085

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
Log:
Change 20080221-hqm-N by hqm at badtzmaru on 2008-02-21 00:18:41 EST
    in /Users/hqm/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix for false error condition in SOLO data loading

New Features:

Bugs Fixed: LPP-4602

Technical Reviewer: andre
QA Reviewer: max
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

Data which is loaded via the LPS proxy service comes wrapped with some
meta-data
including an <error> element  which indicates an error condition.

In SOLO data loading, we should no be scanning for this tag, the SOLO
data loading protocol is to interpret all XML content as user data.
There is
no protocol for signalling a SOLO data load error using data in the
XML content.


Tests:

See test case in bug report LPP-4602



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs	2008-02-21 05:17:12 UTC (rev 8084)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs	2008-02-21 05:19:17 UTC (rev 8085)
@@ -234,7 +234,7 @@
 
         var proxied = dreq.proxied;
 
-        if (data.childNodes[0].nodeName == "error") {
+        if (proxied && data.childNodes[0].nodeName == "error") {
             this.setRequestError(dreq, data.childNodes[0].attributes['msg']);
             dreq.onstatus.sendEvent( dreq );
             return;