[Laszlo-checkins] r12256 - openlaszlo/trunk/WEB-INF/lps/lfc/data

bargull@openlaszlo.org bargull at openlaszlo.org
Sun Dec 28 09:25:05 PST 2008


Author: bargull
Date: 2008-12-28 09:25:00 -0800 (Sun, 28 Dec 2008)
New Revision: 12256

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs
Log:
Change 20081228-bargull-1GF by bargull at dell--p4--2-53 on 2008-12-28 14:48:38
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: fix typing in lazy replication manager

New Features:

Bugs Fixed: LPP-7235

Technical Reviewer: hminsky
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Add "cast LzView" so that swf9 compiles.
    

Tests:
smokecheck for swf8, swf9 and dhtml



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs	2008-12-28 14:01:38 UTC (rev 12255)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzLazyReplicationManager.lzs	2008-12-28 17:25:00 UTC (rev 12256)
@@ -139,8 +139,7 @@
 
     this.cloneAttrs.options = cloneopt;
 
-    // TODO: [20081020 dda] LPP-7031 removed typing, attempts to fix for SWF9 using casts fails smokecheck in DHTML
-    var v/*:LzView*/ = this.getNewClone( true );
+    var v:LzView = (this.getNewClone( true ) cast LzView);
     this.cloneimmediateparent = v.immediateparent;
     
     if (this.initialnodes) {
@@ -278,15 +277,14 @@
 
     for ( var i:int = 0; i < newlength; i++ ){
         //before the new beginning
-        // TODO: [20081020 dda] LPP-7031 removed typing, attempts to fix for SWF9 using casts fails smokecheck in DHTML
-        var cl/*:LzView*/ = null;
+        var cl:LzView = null;
         if ( i + offset < 0 ){
             //this comes before the old data window
             if ( newlength + offset < oldlength  && oldlength > 0){
                 //pull the clone off the end
                 cl = oldclones[ --oldlength ];
             } else {
-                cl = this.getNewClone();
+                cl = (this.getNewClone() cast LzView);
             }
         } else if ( i + offset >= oldlength ){
             //this comes after the old data window
@@ -294,7 +292,7 @@
                 //pull the clone off the end
                 cl = oldclones[ oldstart++ ];
             } else {
-                cl = this.getNewClone();
+                cl = (this.getNewClone() cast LzView);
             }
         }
 
@@ -340,12 +338,11 @@
  * @access private
  */
 override function getCloneForNode ( p:LzDataElement, dontmake:Boolean = false ) :LzNode {
-    // TODO: [20081020 dda] LPP-7031 removed typing, attempts to fix for SWF9 using casts fails smokecheck in DHTML
-    var cl/*:LzView*/ = (super.getCloneForNode( p ) cast LzView) || null;
+    var cl:LzView = (super.getCloneForNode( p ) cast LzView) || null;
     if ( !cl && !dontmake ){
         //even though we're going to return this to the pool immediately,
         //use the class API to get a clone
-        cl = this.getNewClone();
+        cl = (this.getNewClone() cast LzView);
         cl.datapath.setClonePointer( p );
         this.detachClone( cl );
         this.clonePool.push ( cl );



More information about the Laszlo-checkins mailing list