[Laszlo-checkins] r12174 - openlaszlo/trunk/lps/includes/source

[bargull@openlaszlo.org]

Author: bargull
Date: 2008-12-18 07:43:07 -0800 (Thu, 18 Dec 2008)
New Revision: 12174

Modified:
   openlaszlo/trunk/lps/includes/source/iframemanager.js
Log:
Change 20081215-bargull-fzX by bargull at dell--p4--2-53 on 2008-12-15 16:10:12
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: iframe border in IE

New Features:

Bugs Fixed: LPP-7310

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
As always, everything needs to be a bit more complicated in IE.
In this case, the attribute 'frameBorder' is:
- case-sensitive
- and must be set before the iframe was added to the document

From:
http://www.zachleat.com/web/2007/04/24/adventures-in-i-frame-shims-or-how-i-learned-to-love-the-bomb/
http://www.visible-form.com/blog/createelement-and-events-and-iframe-borders/
    

Tests:
see bugreport



Modified: openlaszlo/trunk/lps/includes/source/iframemanager.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/iframemanager.js	2008-12-18 15:42:00 UTC (rev 12173)
+++ openlaszlo/trunk/lps/includes/source/iframemanager.js	2008-12-18 15:43:07 UTC (rev 12174)
@@ -33,6 +33,7 @@
         }
         lz.embed.__setAttr(i, 'id', id);
         if (scrollbars != true) lz.embed.__setAttr(i, 'scrolling', 'no');
+        if (document.all) lz.embed.__setAttr(i, 'frameBorder', '0');
         this.appendTo(id, appendto);
 
         var iframe = lz.embed.iframemanager.getFrame(id);
@@ -46,7 +47,8 @@
             iframe.style.border = '0';
         } else if (document.all) {
             // IE
-            lz.embed.__setAttr(iframe, 'border', '0');
+            // must be set before the iframe is appended to the document (LPP-7310)
+            // lz.embed.__setAttr(iframe, 'frameBorder', '0');
             lz.embed.__setAttr(iframe, 'allowtransparency', 'true');
 
             var metadata = lz.embed[iframe.owner]