[Laszlo-checkins] r12004 - openlaszlo/trunk/WEB-INF/lps/lfc/core

[bargull@openlaszlo.org]

Author: bargull
Date: 2008-12-07 03:37:28 -0800 (Sun, 07 Dec 2008)
New Revision: 12004

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
Log:
Change 20081207-bargull-e8o by bargull at dell--p4--2-53 on 2008-12-07 00:05:58
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: add note to mergeAttributes

New Features:

Bugs Fixed: LPP-7428

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
Add note to mergeAttributes as suggested.
(I've put your name in the NOTE since it is exactly what you've written in your mail.) 
    

Tests:



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs	2008-12-07 09:00:06 UTC (rev 12003)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs	2008-12-07 11:37:28 UTC (rev 12004)
@@ -83,6 +83,11 @@
     for ( var k in attrs ) {
       var attrk = attrs[ k ];
       if ( attrk === LzNode._ignoreAttribute ) {
+        // NOTE: [2008-12-06 ptw] In cloning you are saving
+        // away a half-processed arglist that will be _re_-merged
+        // with the parent class args, so you need to have a way
+        // to memoize the deletion, 
+        // cf. LzReplicationManager#construct()
         delete dattrs[k];
       } else if (attrk is LzInitExpr) {
         dattrs[k] = attrk;