[Laszlo-checkins] r11944 - in openlaszlo/trunk/WEB-INF/lps/lfc: compiler core data helpers kernel/swf kernel/swf9
bargull@openlaszlo.org
bargull at openlaszlo.org
Mon Dec 1 07:54:26 PST 2008
Author: bargull
Date: 2008-12-01 07:54:18 -0800 (Mon, 01 Dec 2008)
New Revision: 11944
Modified:
openlaszlo/trunk/WEB-INF/lps/lfc/compiler/Class.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzFont.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as
openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzBrowserKernel.lzs
Log:
Change 20081128-bargull-Rhp by bargull at dell--p4--2-53 on 2008-11-28 22:53:41
in /home/Admin/src/svn/openlaszlo/trunk
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: UPDATE: schema build warnings
New Features:
Bugs Fixed: LPP-7408 (partial)
Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)
Documentation:
Release Notes:
Details:
Class: Changed profile annotation, so it doesn't use a local (actually global) variable to shorten the assignment expression.
LzNode: added @type
LzFont: mark internal properties as @access private
LzSelectionManager: rename argument to match java-doc
LzMakeLoadSprite: rename argument (also a bugfix..)
LzBrowserKernel: move doc into code (not really important here, it's a kernel class)
LzDataset: rename arg in java-doc to match implementation
LzReplicationManager: rename argument to match java-doc
Tests:
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/compiler/Class.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/compiler/Class.lzs 2008-12-01 14:55:54 UTC (rev 11943)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/compiler/Class.lzs 2008-12-01 15:54:18 UTC (rev 11944)
@@ -25,7 +25,7 @@
* all other classes are created by Class.make (below).
*/
var Instance = function constructor () {
- this.constructor = arguments.callee
+ this.constructor = arguments.callee;
this.$lzsc$initialize.apply(this, arguments);
};
Instance.prototype.constructor = Instance;
@@ -163,8 +163,7 @@
*/
Instance.prototype.addProperty('$lzsc$initialize', function $lzsc$initialize () {});
if ($profile) {
- var ii = Instance.prototype.$lzsc$initialize;
- ii._dbg_name = ii.name = 'Instance';
+ Instance.prototype.$lzsc$initialize._dbg_name = Instance.prototype.$lzsc$initialize.name = 'Instance';
}
/**
@@ -190,8 +189,7 @@
Instance.initialize._dbg_typename = 'Instance static function';
}
if ($profile) {
- var ii = Instance.initialize;
- ii._dbg_name = ii.name = 'Instance.initialize';
+ Instance.initialize._dbg_name = Instance.initialize.name = 'Instance.initialize';
}
if ($debug) {
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs 2008-12-01 14:55:54 UTC (rev 11943)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/core/LzNode.lzs 2008-12-01 15:54:18 UTC (rev 11944)
@@ -468,6 +468,7 @@
* so that nodes can be garbage collected when they are no longer needed.
* See also, immediateparent.
* @keywords readonly
+ * @type LzNode
*/
var parent;
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs 2008-12-01 14:55:54 UTC (rev 11943)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzDataset.lzs 2008-12-01 15:54:18 UTC (rev 11944)
@@ -620,7 +620,7 @@
* Sets multiple query parameters from using the keys in the argument as keys
* and the values of those keys as values. This method can also be used to
* clear the query params, by passing null to it.
- * @param Object o: An object whose keys are keys of parameters and whose
+ * @param Object obj: An object whose keys are keys of parameters and whose
* values are those parameters' values. Passing a value of null to this
* method clears the query parameters.
* The key 'lzpostbody' has a specific interpretation, see setQueryType() for details.
@@ -993,7 +993,7 @@
/**
* Recyles a dataset back into the pool for reuse
- * @param d: The dataset to be recycled
+ * @param dset: The dataset to be recycled
*/
function recycle (dset:LzDataset) :void {
// clear any request-parameter stuff
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs 2008-12-01 14:55:54 UTC (rev 11943)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/data/LzReplicationManager.lzs 2008-12-01 15:54:18 UTC (rev 11944)
@@ -701,8 +701,8 @@
* @deprecated Use setAttribute('datapath', ...) instead.
* @access private
*/
-override function $lzc$set_datapath(v) :void {
- this.setXPath(v);
+override function $lzc$set_datapath(xp) :void {
+ this.setXPath(xp);
}
/**
@@ -763,9 +763,9 @@
* reason for this to be a public method.
* @deprecated Use setAttribute('visible', ...) instead.
*/
-function setVisible(v:Boolean) :void {
+function setVisible(vis:Boolean) :void {
if ($debug) Debug.deprecated(this, arguments.callee, this.setAttribute);
- this.$lzc$set_visible(v);
+ this.$lzc$set_visible(vis);
}
/** @access private */
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzFont.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzFont.lzs 2008-12-01 14:55:54 UTC (rev 11943)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzFont.lzs 2008-12-01 15:54:18 UTC (rev 11944)
@@ -351,6 +351,7 @@
*/
var rsbtable;
+/** @access private */
var fontobject;
@@ -377,7 +378,9 @@
}
/** This is a constant set in the textfield the runtime uses. should match the
- * value set in SWFWriter.java */
+ * value set in SWFWriter.java
+ * @access private
+ */
var leading = 2;
public function toString (){
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs 2008-12-01 14:55:54 UTC (rev 11943)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs 2008-12-01 15:54:18 UTC (rev 11944)
@@ -133,7 +133,7 @@
var lastRangeStart :*;
/**
- * @param LzView view: A view above this one in the hierarchy that will determine
+ * @param LzView parent: A view above this one in the hierarchy that will determine
* the placement of the selection manager.
* @param Object args: A hash of initialization arguments
*
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as 2008-12-01 14:55:54 UTC (rev 11943)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf/LzMakeLoadSprite.as 2008-12-01 15:54:18 UTC (rev 11944)
@@ -58,7 +58,7 @@
* @param String headers: Headers to send with the request (if any.)
* @param String filetype: Filetype, e.g. 'mp3' or 'jpg'. If not specified, it will be derived from the URL.
*/
-LzMakeLoadSprite.setSource = function (src, cache, header, filetype) {
+LzMakeLoadSprite.setSource = function (src, cache, headers, filetype) {
// unload anything currently loading...
if (this.loader.mc.loading == true) {
LzLoadQueue.unloadRequest(this.loader.mc);
Modified: openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzBrowserKernel.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzBrowserKernel.lzs 2008-12-01 14:55:54 UTC (rev 11943)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/kernel/swf9/LzBrowserKernel.lzs 2008-12-01 15:54:18 UTC (rev 11944)
@@ -51,11 +51,9 @@
/**
* Runs a Javascript method in the browser, returning the result
* @keywords flashspecific
- *
- * @param String js: Browser javascript to execute
*/
static function callJS (...args) {
- var js = args[0];
+ var js = args[0];// String js: Browser javascript to execute
var callback = args[1];
//DojoExternalInterface.call.apply(null, args);
if (LzBrowserKernel.jsready != true) {
More information about the Laszlo-checkins
mailing list