[Laszlo-checkins] r10639 - openlaszlo/trunk/lps/includes/source

[max@openlaszlo.org]

Author: max
Date: 2008-08-07 21:58:10 -0700 (Thu, 07 Aug 2008)
New Revision: 10639

Modified:
   openlaszlo/trunk/lps/includes/source/embednew.js
Log:
Should have gone with:
Author: max
Date: 2008-08-07 20:19:02 -0700 (Thu, 07 Aug 2008)
New Revision: 10638

Modified:
   openlaszlo/trunk/lps/includes/source/embednew.js
   openlaszlo/trunk/lps/includes/source/lzhistory.js
Log:
Change 20080807-maxcarlson-x by maxcarlson at Roboto on 2008-08-07 15:33:12 PDT
    in /Users/maxcarlson/openlaszlo/trunk-clean
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Prevent history from updating when disabled

Bugs Fixed: LPP-6813 - history mechanism should prevent updates when disabled.

Technical Reviewer: promanik
QA Reviewer: hminsky

Details: embednew.js - Set lz.embed.history.active flag to false when an app is embedded with history: false.

lzhistory.js - Add active flag.  If active != true, return immediately in set().

Tests: Apps show as before in swf8/9/dhtml



Modified: openlaszlo/trunk/lps/includes/source/embednew.js
===================================================================
--- openlaszlo/trunk/lps/includes/source/embednew.js	2008-08-08 03:19:02 UTC (rev 10638)
+++ openlaszlo/trunk/lps/includes/source/embednew.js	2008-08-08 04:58:10 UTC (rev 10639)
@@ -218,7 +218,9 @@
             ,getCanvasAttribute: lz.embed._getCanvasAttributeDHTML
         }
         // listen for history unless properties.history == false
-        if (properties.history != false) {
+        if (properties.history == false) {
+            lz.embed.history.active = false;
+        } else {
             app._onload.push(lz.embed.history.init);
         }