[Laszlo-checkins] r8612 - in openlaszlo/trunk/WEB-INF/lps: lfc/debugger/platform/swf server/src/org/openlaszlo/servlets/responders

[hqm@openlaszlo.org]

Author: hqm
Date: 2008-04-09 18:33:24 -0700 (Wed, 09 Apr 2008)
New Revision: 8612

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/debugger/platform/swf/LzFlashRemote.as
   openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderEVAL.java
Log:
Change 20080409-hqm-P by hqm at badtzmaru.local on 2008-04-09 21:32:16 EDT
    in /Users/hqm/openlaszlo/trunk5
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary:  fix for LPP-5741, eval button in remote console debug doesn't work

New Features:

Bugs Fixed:  	 LPP-5741

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:

The LPS server was getting a null pointer error because I had modified
evalResponder for swf9, and didn't check if lzr was not supplied. It
is modified now to default to swf8 if no lzr query arg is supplied. 

Tests:

run app with remote debug console, evaluate an expression successfully



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/debugger/platform/swf/LzFlashRemote.as
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/debugger/platform/swf/LzFlashRemote.as	2008-04-10 01:32:37 UTC (rev 8611)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/debugger/platform/swf/LzFlashRemote.as	2008-04-10 01:33:24 UTC (rev 8612)
@@ -8,7 +8,7 @@
   * @access private
   * @topic Kernel
   * @subtopic AS2
-  * @copyright Copyright 2001-2007 Laszlo Systems, Inc.  All Rights Reserved.
+  * @copyright Copyright 2001-2008 Laszlo Systems, Inc.  All Rights Reserved.
   *            Use is subject to license terms.
   */
 
@@ -70,7 +70,7 @@
   */
 Debug.cdEvalExpression = function (expr) {
     Debug.inEvalRequest = true;
-    var req = "foo.lzx?lzt=eval&lz_script="+escape("#file evalString\n#line 0\n" + expr);
+    var req = "foo.lzx?lzr=swf8&lzt=eval&lz_script="+escape("#file evalString\n#line 0\n" + expr);
     Debug.crdbloader.loadMovie( req );
 }
 

Modified: openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderEVAL.java
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderEVAL.java	2008-04-10 01:32:37 UTC (rev 8611)
+++ openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderEVAL.java	2008-04-10 01:33:24 UTC (rev 8612)
@@ -68,6 +68,9 @@
                 res.setContentType(MimeType.SWF);
                 Compiler compiler = new Compiler();
                 String swfversion = req.getParameter("lzr");
+                if (swfversion == null) {
+                    swfversion = "swf8";
+                }
                 if ("swf9".equals(swfversion)) {
                     compiler.compileAndWriteToSWF9(script, seqnum, out);
                 } else {