[Laszlo-checkins] r8545 - in openlaszlo/trunk: WEB-INF/lps/server/src/org/openlaszlo/compiler test/compiler_errors

[hqm@openlaszlo.org]

Author: hqm
Date: 2008-04-03 16:15:56 -0700 (Thu, 03 Apr 2008)
New Revision: 8545

Added:
   openlaszlo/trunk/test/compiler_errors/invalid-node-name.lzx
Modified:
   openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
Log:
Change 20080403-hqm-K by hqm at badtzmaru.local on 2008-04-03 16:15:22 EDT
    in /Users/hqm/openlaszlo/trunk2
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: check for invalid javascript identifier in LZX node names

New Features:

Bugs Fixed:

Technical Reviewer: ptw
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
    

Tests:

catches lzpix "beveled-divider" error

test case in 
  test/compiler_errors/invalid-node-name.lzx




Modified: openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java	2008-04-03 21:24:46 UTC (rev 8544)
+++ openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java	2008-04-03 23:15:56 UTC (rev 8545)
@@ -763,6 +763,14 @@
                 }
             }
 
+            // Check that the view name is a valid javascript identifier
+            if ((name.equals("name") || name.equals("id")) &&
+                (value == null || !ScriptCompiler.isIdentifier(value))) {
+                CompilationError cerr = new CompilationError(
+                    "The "+name+" attribute of this node,  "+ "\"" + value + "\", is not a valid javascript identifier " , element);
+                throw(cerr);
+            }
+
             Schema.Type type;
             try {
                 if ("class".equals(className) || "interface".equals(className) || "mixin".equals(className)) {

Added: openlaszlo/trunk/test/compiler_errors/invalid-node-name.lzx


Property changes on: openlaszlo/trunk/test/compiler_errors/invalid-node-name.lzx
___________________________________________________________________
Name: svn:mime-type
   + text/plain
Name: svn:eol-style
   + native