[Laszlo-checkins] r7417 - openlaszlo/trunk/WEB-INF/lps/lfc/views

bargull@openlaszlo.org bargull at openlaszlo.org
Thu Nov 29 15:01:08 PST 2007


Author: bargull
Date: 2007-11-29 15:01:05 -0800 (Thu, 29 Nov 2007)
New Revision: 7417

Modified:
   openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs
Log:
Change 20071128-bargull-4 by bargull at dell--p4--2-53 on 2007-11-28 23:49:42
    in /home/Admin/src/svn/openlaszlo/trunk
    for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: revert setVisibility("hidden") call in LzView#destroy(..)

New Features:

Bugs Fixed: LPP-5127 "Memory leak in window"

Technical Reviewer: ptw
QA Reviewer: hminsky
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
As already discussed on laszlo-dev, we're reverting the call to setVisibility("hidden") and we'll use again setVisible(false), so that basewindow won't leak memory anymore.


Tests:
see bugreport



Modified: openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs	2007-11-29 22:44:37 UTC (rev 7416)
+++ openlaszlo/trunk/WEB-INF/lps/lfc/views/LaszloView.lzs	2007-11-29 23:01:05 UTC (rev 7417)
@@ -1163,7 +1163,7 @@
 
     //this.__LZFinishDestroyOnIdle();
 
-    this.setVisibility ( "hidden" );
+    this.setVisible ( false );
 
     if ( this.addedToParent ){
          if ( ('__LZoutliewidth' in this.immediateparent) && (this.immediateparent.__LZoutliewidth == this) ) {



More information about the Laszlo-checkins mailing list