[Laszlo-checkins] r3912 - openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc

ptw@openlaszlo.org ptw at openlaszlo.org
Fri Feb 23 13:18:10 PST 2007


Author: ptw
Date: 2007-02-23 13:18:08 -0800 (Fri, 23 Feb 2007)
New Revision: 3912

Modified:
   openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
Log:
Change 20070223-ptw-3 by ptw at dueling-banjos.local on 2007-02-23 13:15:47 PST
    in /Users/ptw/OpenLaszlo/trunk-clean

Summary: Fix broken compiler assertion

Technical Reviewer: me
QA Reviewer: me
Doc Reviewer: me

Details:
    Apparently I am the only member of the platform team that runs
    with assertions on, and apparently, I just compiled the first app
    that contains a comma-separated list of expressions.

Tests:
    No assertions for me!

Modified: openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
===================================================================
--- openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java	2007-02-23 20:43:50 UTC (rev 3911)
+++ openlaszlo/trunk/WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java	2007-02-23 21:18:08 UTC (rev 3912)
@@ -1464,9 +1464,7 @@
     // endsWith tests for.
     String name = node.getClass().getName();
     return name.endsWith("Expression") ||
-      // TODO: [2006-01-11 ptw] Noone can explain this vestigial code, remove it
-      //         name.substring(5).equals("ExpressionList") ||
-      //         name.substring(5).equals("Identifier") ||
+      name.endsWith("ExpressionList") ||
       name.endsWith("ExpressionSequence") ||
       name.endsWith("Identifier") ||
       name.endsWith("Literal") ||



More information about the Laszlo-checkins mailing list