[Laszlo-checkins] r3865 - in openlaszlo/branches/legals/WEB-INF/lps: config server/src/org/openlaszlo/sc

[ptw@openlaszlo.org]

Author: ptw
Date: 2007-02-21 14:36:37 -0800 (Wed, 21 Feb 2007)
New Revision: 3865

Modified:
   openlaszlo/branches/legals/WEB-INF/lps/config/lps.properties
   openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
   openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
Log:
Change 20070221-ptw-T by ptw at dueling-banjos.local on 2007-02-21 13:00:06 PST
    in /Users/ptw/OpenLaszlo/legals-1

Summary: Allow debugging in Safari 2

Bugs Fixed:
LPP-3579: 'Fix debugger in Safari'

Technical Reviewer: max (Message-ID: <45DCC64F.9090105 at openlaszlo.org>)
QA Reviewer: hminsky (pending)
Doc Reviewer: jsundman (pending)

Documentation:

In lps.properties you can set compiler.debug.safari to true to allow
debugging in Safari.  This is not on by default because it makes
debugging less useful in Firefox (backtaces will not see function
names).

Details:
    lps.properties: Document option

    Compiler: Look for compiler.debug.safari property

    JavascriptGenerator: Don't name function expressions if that flag
    is on.

Tests:
    IWFMax

Modified: openlaszlo/branches/legals/WEB-INF/lps/config/lps.properties
===================================================================
--- openlaszlo/branches/legals/WEB-INF/lps/config/lps.properties	2007-02-21 21:21:37 UTC (rev 3864)
+++ openlaszlo/branches/legals/WEB-INF/lps/config/lps.properties	2007-02-21 22:36:37 UTC (rev 3865)
@@ -151,6 +151,9 @@
 compiler.runtime.default=swf7
 # Turn backtraces on in the debugger (slower, off by default)
 #compiler.debug.backtrace=true
+# TODO: Remove after Leopard
+# Safari debugging compatibility (of by default)
+#compiler.debug.safari=true
 # Warn on global assignments (off by default)
 #compiler.warn.globalassignments=true
 

Modified: openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
===================================================================
--- openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java	2007-02-21 21:21:37 UTC (rev 3864)
+++ openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java	2007-02-21 22:36:37 UTC (rev 3865)
@@ -286,6 +286,8 @@
         options.put(DEBUG_BACKTRACE,
                     Boolean.valueOf(LPS.getProperty("compiler.debug.backtrace", "false")));
       }
+      // TODO: [2007-02-21 ptw] Remove after Leopard
+      options.put("debugSafari", LPS.getProperty("compiler.debug.safari", "false"));
     }
     if (! options.containsKey(PROFILE)) {
       options.putBoolean(PROFILE, false);

Modified: openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
===================================================================
--- openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java	2007-02-21 21:21:37 UTC (rev 3864)
+++ openlaszlo/branches/legals/WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java	2007-02-21 22:36:37 UTC (rev 3865)
@@ -1674,7 +1674,9 @@
     if (functionName != null) {
       userFunctionName = functionName;
       if (! useName) {
-        if (! identifierPattern.matcher(functionName).matches()) {
+        if ((! identifierPattern.matcher(functionName).matches())
+            // TODO: [2007-02-21 ptw] Remove after Leopard
+            || options.getBoolean("debugSafari")) {
           // This is a function-expression that has been annotated
           // with a non-legal function name, so remove that and put it
           // in _dbg_name (below)